Skip to content

Commit 1e61511

Browse files
authored
fix!: TaskState.UNRECOGNIZED is called TASK_STATE_UNSPECIFIED in spec (a2aproject#974)
* fix!: `TaskState.UNRECOGNIZED` is called `TaskState.TASK_STATE_UNSPECIFIED` in spec BREAKING CHANGE: This is an actual bug in our implementation so it was seen as suitable for a micro release. Users compiling against `UNRECOGNIZED` will need to replace this with `TASK_STATE_UNSPECIFIED`. Also, `TaskState.TASK_STATE_UNSPECIFIED` is not a terminal state
1 parent dae30d2 commit 1e61511

5 files changed

Lines changed: 18 additions & 18 deletions

File tree

‎client/base/src/main/java/org/a2aproject/sdk/client/ClientTaskManager.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ synchronized Task saveTaskEvent(TaskStatusUpdateEvent taskStatusUpdateEvent) thr
6060
Task task = currentTask;
6161
if (task == null) {
6262
task = Task.builder()
63-
.status(new TaskStatus(TaskState.UNRECOGNIZED))
63+
.status(new TaskStatus(TaskState.TASK_STATE_UNSPECIFIED))
6464
.id(taskId)
6565
.contextId(contextId == null ? "" : contextId)
6666
.build();
@@ -96,7 +96,7 @@ synchronized Task saveTaskEvent(TaskArtifactUpdateEvent taskArtifactUpdateEvent)
9696
Task task = currentTask;
9797
if (task == null) {
9898
task = Task.builder()
99-
.status(new TaskStatus(TaskState.UNRECOGNIZED))
99+
.status(new TaskStatus(TaskState.TASK_STATE_UNSPECIFIED))
100100
.id(taskId)
101101
.contextId(contextId == null ? "" : contextId)
102102
.build();

‎compat-0.3/server-conversion/src/main/java/org/a2aproject/sdk/compat03/conversion/mappers/domain/TaskStateMapper_v0_3.java‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@
1515
* <li>v1.0: {@code TASK_STATE_SUBMITTED, TASK_STATE_WORKING, ...}</li>
1616
* </ul>
1717
* <p>
18-
* Additionally, the {@code UNKNOWN} state in v0.3 maps to {@code UNRECOGNIZED} in v1.0.
18+
* Additionally, the {@code UNKNOWN} state in v0.3 maps to {@code TASK_STATE_UNSPECIFIED} in v1.0.
1919
* <p>
2020
* This mapper uses manual switch statements instead of {@code @ValueMapping} to:
2121
* <ul>
2222
* <li>Avoid mapstruct-spi-protobuf enum strategy initialization issues</li>
23-
* <li>Handle explicit null mapping (null → UNRECOGNIZED/UNKNOWN)</li>
23+
* <li>Handle explicit null mapping (null → TASK_STATE_UNSPECIFIED/UNKNOWN)</li>
2424
* <li>Provide clear, compile-time-safe enum conversions</li>
2525
* </ul>
2626
*
@@ -50,16 +50,16 @@ public interface TaskStateMapper_v0_3 {
5050
* CANCELED → TASK_STATE_CANCELED
5151
* FAILED → TASK_STATE_FAILED
5252
* REJECTED → TASK_STATE_REJECTED
53-
* UNKNOWN → UNRECOGNIZED
54-
* null → UNRECOGNIZED
53+
* UNKNOWN → TASK_STATE_UNSPECIFIED
54+
* null → TASK_STATE_UNSPECIFIED
5555
* </pre>
5656
*
5757
* @param v03 the v0.3 task state (may be null)
5858
* @return the equivalent v1.0 task state (never null)
5959
*/
6060
default TaskState toV10(TaskState_v0_3 v03) {
6161
if (v03 == null) {
62-
return TaskState.UNRECOGNIZED;
62+
return TaskState.TASK_STATE_UNSPECIFIED;
6363
}
6464
return switch (v03) {
6565
case SUBMITTED -> TaskState.TASK_STATE_SUBMITTED;
@@ -70,7 +70,7 @@ default TaskState toV10(TaskState_v0_3 v03) {
7070
case CANCELED -> TaskState.TASK_STATE_CANCELED;
7171
case FAILED -> TaskState.TASK_STATE_FAILED;
7272
case REJECTED -> TaskState.TASK_STATE_REJECTED;
73-
case UNKNOWN -> TaskState.UNRECOGNIZED;
73+
case UNKNOWN -> TaskState.TASK_STATE_UNSPECIFIED;
7474
};
7575
}
7676

@@ -89,7 +89,7 @@ default TaskState toV10(TaskState_v0_3 v03) {
8989
* TASK_STATE_CANCELED → CANCELED
9090
* TASK_STATE_FAILED → FAILED
9191
* TASK_STATE_REJECTED → REJECTED
92-
* UNRECOGNIZED → UNKNOWN
92+
* TASK_STATE_UNSPECIFIED → UNKNOWN
9393
* null → UNKNOWN
9494
* </pre>
9595
*
@@ -109,7 +109,7 @@ default TaskState_v0_3 fromV10(TaskState v10) {
109109
case TASK_STATE_CANCELED -> TaskState_v0_3.CANCELED;
110110
case TASK_STATE_FAILED -> TaskState_v0_3.FAILED;
111111
case TASK_STATE_REJECTED -> TaskState_v0_3.REJECTED;
112-
case UNRECOGNIZED -> TaskState_v0_3.UNKNOWN;
112+
case TASK_STATE_UNSPECIFIED -> TaskState_v0_3.UNKNOWN;
113113
};
114114
}
115115
}

‎spec-grpc/src/main/java/org/a2aproject/sdk/grpc/mapper/A2ACommonFieldMapper.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ default org.a2aproject.sdk.spec.TaskState taskStateOrNull(org.a2aproject.sdk.grp
445445
// Reject invalid enum values (e.g., "INVALID_STATUS" from JSON)
446446
if (state == org.a2aproject.sdk.grpc.TaskState.UNRECOGNIZED) {
447447
String validStates = java.util.Arrays.stream(org.a2aproject.sdk.spec.TaskState.values())
448-
.filter(s -> s != org.a2aproject.sdk.spec.TaskState.UNRECOGNIZED)
448+
.filter(s -> s != org.a2aproject.sdk.spec.TaskState.TASK_STATE_UNSPECIFIED)
449449
.map(Enum::name)
450450
.collect(java.util.stream.Collectors.joining(", "));
451451
throw new InvalidParamsError(null,

‎spec-grpc/src/main/java/org/a2aproject/sdk/grpc/mapper/TaskStateMapper.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,19 +38,19 @@ default org.a2aproject.sdk.grpc.TaskState toProto(org.a2aproject.sdk.spec.TaskSt
3838
case TASK_STATE_CANCELED -> org.a2aproject.sdk.grpc.TaskState.TASK_STATE_CANCELED;
3939
case TASK_STATE_FAILED -> org.a2aproject.sdk.grpc.TaskState.TASK_STATE_FAILED;
4040
case TASK_STATE_REJECTED -> org.a2aproject.sdk.grpc.TaskState.TASK_STATE_REJECTED;
41-
case UNRECOGNIZED -> org.a2aproject.sdk.grpc.TaskState.UNRECOGNIZED;
41+
case TASK_STATE_UNSPECIFIED -> org.a2aproject.sdk.grpc.TaskState.TASK_STATE_UNSPECIFIED;
4242
};
4343
}
4444

4545
/**
4646
* Converts proto TaskState to domain TaskState.
4747
*
4848
* @param proto the proto task state
49-
* @return the domain task state, or UNKNOWN if input is null or unrecognized
49+
* @return the domain task state, or TASK_STATE_UNSPECIFIED if input is null or unrecognized
5050
*/
5151
default org.a2aproject.sdk.spec.TaskState fromProto(org.a2aproject.sdk.grpc.TaskState proto) {
5252
if (proto == null) {
53-
return org.a2aproject.sdk.spec.TaskState.UNRECOGNIZED;
53+
return org.a2aproject.sdk.spec.TaskState.TASK_STATE_UNSPECIFIED;
5454
}
5555

5656
return switch (proto) {
@@ -62,7 +62,7 @@ default org.a2aproject.sdk.spec.TaskState fromProto(org.a2aproject.sdk.grpc.Task
6262
case TASK_STATE_CANCELED -> org.a2aproject.sdk.spec.TaskState.TASK_STATE_CANCELED;
6363
case TASK_STATE_FAILED -> org.a2aproject.sdk.spec.TaskState.TASK_STATE_FAILED;
6464
case TASK_STATE_REJECTED -> org.a2aproject.sdk.spec.TaskState.TASK_STATE_REJECTED;
65-
case TASK_STATE_UNSPECIFIED, UNRECOGNIZED -> org.a2aproject.sdk.spec.TaskState.UNRECOGNIZED;
65+
case TASK_STATE_UNSPECIFIED, UNRECOGNIZED -> org.a2aproject.sdk.spec.TaskState.TASK_STATE_UNSPECIFIED;
6666
};
6767
}
6868
}

‎spec/src/main/java/org/a2aproject/sdk/spec/TaskState.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
* <li><b>TASK_STATE_CANCELED:</b> Task was explicitly canceled by the user or system</li>
2828
* <li><b>TASK_STATE_FAILED:</b> Task failed due to an error during execution</li>
2929
* <li><b>TASK_STATE_REJECTED:</b> Task was rejected by the agent (e.g., invalid request, policy violation)</li>
30-
* <li><b>UNRECOGNIZED:</b> Task state cannot be determined (error recovery state)</li>
30+
* <li><b>TASK_STATE_UNSPECIFIED:</b> Task state cannot be determined (error recovery state)</li>
3131
* </ul>
3232
* <p>
3333
* The {@link #isFinal()} method can be used to determine if a state is terminal, which is
@@ -64,7 +64,7 @@ public enum TaskState {
6464
TASK_STATE_REJECTED(true, false),
6565

6666
/** Task state is unknown or cannot be determined (terminal state). */
67-
UNRECOGNIZED(true, false);
67+
TASK_STATE_UNSPECIFIED(false, false);
6868

6969
private final boolean isFinal;
7070
private final boolean isInterrupted;
@@ -81,7 +81,7 @@ public enum TaskState {
8181
* not transition to any other state. This is used by the event queue system
8282
* to determine when to close queues and by clients to know when to stop polling.
8383
* <p>
84-
* Terminal states: COMPLETED, FAILED, CANCELED, REJECTED, UNRECOGNIZED.
84+
* Terminal states: TASK_STATE_COMPLETED, TASK_STATE_FAILED, TASK_STATE_CANCELED, TASK_STATE_REJECTED, TASK_STATE_UNSPECIFIED.
8585
*
8686
* @return {@code true} if this is a terminal state, {@code false} else.
8787
*/

0 commit comments

Comments
 (0)