|
26 | 26 | import org.a2aproject.sdk.server.config.DefaultValuesConfigProvider; |
27 | 27 | import org.a2aproject.sdk.server.multitenancy.AgentCardRouter; |
28 | 28 | import org.a2aproject.sdk.server.requesthandlers.AbstractA2ARequestHandlerTest; |
| 29 | +import org.a2aproject.sdk.server.requesthandlers.LogCaptureAssertions; |
29 | 30 | import org.a2aproject.sdk.server.requesthandlers.RequestHandler; |
30 | 31 | import org.a2aproject.sdk.spec.AgentCapabilities; |
31 | 32 | import org.a2aproject.sdk.spec.AgentCard; |
@@ -457,6 +458,33 @@ public void testListPushNotificationConfigs() { |
457 | 458 | Assertions.assertNotNull(response.getBody()); |
458 | 459 | } |
459 | 460 |
|
| 461 | + @Test |
| 462 | + public void testPushNotificationConfigParseError_DoesNotLogSensitiveData() { |
| 463 | + RestHandler handler = new RestHandler(CARD, createCacheMetadata(), requestHandler, internalExecutor); |
| 464 | + taskStore.save(MINIMAL_TASK, false); |
| 465 | + |
| 466 | + String requestBody = """ |
| 467 | + { |
| 468 | + "id": "default-config-id", |
| 469 | + "taskId": "%s", |
| 470 | + "url": "https://webhook.example.com", |
| 471 | + "token": "secret-token-12345", |
| 472 | + "authentication": { |
| 473 | + "scheme": "Bearer", |
| 474 | + "credentials": "oauth-secret-67890" |
| 475 | + }, |
| 476 | + "unknownField": "trigger-parse-error" |
| 477 | + }""".formatted(MINIMAL_TASK.id()); |
| 478 | + |
| 479 | + // Request body with sensitive data and an unknown field to trigger parse error |
| 480 | + java.util.logging.Logger logger = java.util.logging.Logger.getLogger(RestHandler.class.getName()); |
| 481 | + LogCaptureAssertions.assertSensitiveDataNotLogged(logger, |
| 482 | + () -> Assertions.assertEquals(422, |
| 483 | + handler.createTaskPushNotificationConfiguration(callContext, "", requestBody, MINIMAL_TASK.id()) |
| 484 | + .getStatusCode()), |
| 485 | + "secret-token-12345", "oauth-secret-67890"); |
| 486 | + } |
| 487 | + |
460 | 488 | @Test |
461 | 489 | public void testHttpStatusCodeMapping() { |
462 | 490 | RestHandler handler = new RestHandler(CARD, createCacheMetadata(), requestHandler, internalExecutor); |
|
0 commit comments