refactor: Simplify derive macro implementation - #16
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactor to simplify the derive macro implementation and address remaining clippy warnings; this PR also bumps crate versions to 0.1.6 to reflect the changes.
- Bump gonfig and gonfig_derive crate versions to 0.1.6
- Align published versions across crates
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gonfig_derive/Cargo.toml | Bump derive crate version to 0.1.6 |
| Cargo.toml | Bump main crate version to 0.1.6 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Code Simplification
setup_env_clicode block to eliminate duplication betweenfrom_gonfig_with_builder()andgonfig_builder()methodsallow_envvariableCode Quality
clippy::uninlined_format_argswarnings in core library:src/builder.rssrc/cli.rssrc/config.rsBenefits
Test plan
-D warnings