Skip to content

Commit 9f157c0

Browse files
committed
fix: improve model editing logic and handle missing workspace_id gracefully
1 parent f42589e commit 9f157c0

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

‎apps/models_provider/serializers/model_serializer.py‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,11 @@
77

88
import uuid_utils.compat as uuid
99
from common.config.embedding_config import ModelManage
10-
from common.constants.cache_version import Cache_Version
11-
from common.constants.resource_permission_constants import ResourceAuthType
1210
from common.database_model_manage.database_model_manage import DatabaseModelManage
1311
from common.db.search import native_search
1412
from common.exception.app_exception import AppApiException
1513
from common.utils.common import get_file_content
1614
from common.utils.rsa_util import rsa_long_decrypt, rsa_long_encrypt
17-
from django.core.cache import cache
1815
from django.db import transaction
1916
from django.db.models import QuerySet
2017
from django.utils.translation import gettext_lazy as _
@@ -207,9 +204,12 @@ def delete(self, with_valid=True):
207204

208205
def edit(self, instance: Dict, user_id: str, with_valid=True):
209206
if with_valid:
210-
self.is_valid(raise_exception=True)
211-
model = QuerySet(Model).filter(id=self.data.get("id"), workspace_id=self.data.get("workspace_id")).first()
212-
207+
super().is_valid(raise_exception=True)
208+
model = (
209+
QuerySet(Model)
210+
.filter(id=self.data.get("id"), workspace_id=self.data.get("workspace_id", "None"))
211+
.first()
212+
)
213213
credential, model_credential, provider_handler = ModelSerializer.Edit(data={**instance}).is_valid(
214214
model=model
215215
)

0 commit comments

Comments
 (0)