More error handling for faves, update README with XML format

Author: politebot

README.md

@@ -15,6 +15,47 @@ A simple internet radio player built with the Enlightenment Foundation Libraries
 - List stations with their favicons
 - Play, pause, and stop radio streams
 - Search by station name, country, language, or tag
+- Save favorite radio stations locally
+- Add custom radio station URLs manually
+
+## Favorites Storage
+
+Favorite radio stations are saved locally in XML format at:
+```
+~/.config/eradio/favorites.xml
+```
+
+### XML Format
+
+The favorites file uses a simple XML structure to store station metadata:
+
+```xml
+<?xml version="1.0" encoding="UTF-8"?>
+<favorites version="1">
+  <station uuid="station-uuid-here" name="Station Name"
+           url="http://example.com/stream.mp3"
+           favicon="http://example.com/icon.png"/>
+  <station uuid="another-uuid" name="Another Station"
+           url="http://example.org/stream"/>
+</favorites>
+```
+
+### Element Attributes
+
+Each `<station>` element can contain the following attributes:
+
+- **`uuid`** (optional): Unique identifier from the radio-browser.info API
+- **`name`** (optional): Human-readable station name
+- **`url`** (optional): Stream URL for the radio station
+- **`favicon`** (optional): URL to the station's favicon image
+
+**Note:** Either `uuid` or `url` must be present for a station entry to be valid. The `uuid` is used as the primary key when available, with `url` as fallback.
+
+### File Operations
+
+- The file is automatically created when you add your first favorite station
+- Favorites are saved atomically using a temporary file and rename operation
+- The file can be manually edited - changes will be loaded when the application starts
 
 ## Prerequisites
 

src/favorites.c

@@ -5,6 +5,7 @@
 #include <errno.h>
 #include <string.h>
 #include <stdlib.h>
+#include <stdio.h>
 
 #include "favorites.h"
 
@@ -188,12 +189,36 @@ void favorites_save(AppData *ad)
 
     eina_hash_foreach(ad->favorites, _favorites_save_cb, root);
 
-    xmlSaveFormatFileEnc(tmp, doc, "UTF-8", 1);
+    int xml_save_result = xmlSaveFormatFileEnc(tmp, doc, "UTF-8", 1);
     xmlFreeDoc(doc);
 
-    rename(tmp, path);
+    if (xml_save_result == -1) {
+        // XML save failed - could be disk space, permissions, etc.
+        if (ad->statusbar) {
+            elm_object_text_set(ad->statusbar, "Error: Could not save favorites (disk full?)");
+        }
+        unlink(tmp); // Clean up the temp file
+        free(tmp);
+        goto end;
+    }
+
+    if (rename(tmp, path) == -1) {
+        // Rename failed - could be filesystem issues
+        if (ad->statusbar) {
+            elm_object_text_set(ad->statusbar, "Error: Could not save favorites (filesystem error)");
+        }
+        unlink(tmp); // Clean up the temp file
+        free(tmp);
+        goto end;
+    }
+
     free(tmp);
 
+    // Success - provide feedback to user
+    if (ad->statusbar) {
+        elm_object_text_set(ad->statusbar, "Favorites saved successfully");
+    }
+
 end:
     if (dir) free(dir);
     if (path) free(path);