Repository navigation
Add synchronous Midas withdrawal helper - #229
Closed
LukeHackett12 wants to merge 3 commits into
Closed
LukeHackett12 wants to merge 3 commits into
LukeHackett12 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a stateless
SyncMidasWithdrawalhelper in the same style asSyncWithdrawal. The caller supplieswithdrawAmount,repayAmount,useTarget, andstrategy; the helper callswithdrawManager → commit → unlock.The redeem order must already exist, its bond leg must be complete, and instant redemption must be unlocked. Facility, position manager, and fund contracts enforce their existing validation and lifecycle checks.
Only the helper and
MorphoFlashLoanRequest.t.solchange, based on cleanmain(6998ffd). The integration test covers both withdrawal strategies, exact repayment, settlement, and flash-loan repayment using the existing MockFund.Validation:
FOUNDRY_PROFILE=ci forge build --sizesandgit diff --checkpass.