Skip to content

Commit 8aea2a4

Browse files
author
FrancescoMauto
committed
[DSC-2417] fix: a11y for grid view mode
1 parent 31ebb59 commit 8aea2a4

12 files changed

Lines changed: 22 additions & 18 deletions

File tree

‎src/app/entity-groups/journal-entities/item-grid-elements/search-result-grid-elements/journal-issue/journal-issue-search-result-grid-element.component.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
</span>
2121
<div class="card-body">
2222
<ds-themed-badges *ngIf="showLabel" [object]="dso" [context]="context"></ds-themed-badges>
23-
<ds-truncatable-part [id]="dso.id" [minLines]="3" type="h4">
24-
<h4 class="card-title" [innerHTML]="dsoTitle"></h4>
23+
<ds-truncatable-part [id]="dso.id" [minLines]="3" type="h2">
24+
<h2 class="card-title" [innerHTML]="dsoTitle"></h2>
2525
</ds-truncatable-part>
2626
<p *ngIf="dso.hasMetadata('creativework.datePublished')"
2727
class="item-date card-text text-muted">

‎src/app/entity-groups/journal-entities/item-grid-elements/search-result-grid-elements/journal-volume/journal-volume-search-result-grid-element.component.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
</span>
2121
<div class="card-body">
2222
<ds-themed-badges *ngIf="showLabel" [object]="dso" [context]="context"></ds-themed-badges>
23-
<ds-truncatable-part [id]="dso.id" [minLines]="3" type="h4">
24-
<h4 class="card-title" [innerHTML]="dsoTitle"></h4>
23+
<ds-truncatable-part [id]="dso.id" [minLines]="3" type="h2">
24+
<h2 class="card-title" [innerHTML]="dsoTitle"></h2>
2525
</ds-truncatable-part>
2626
<p *ngIf="dso.hasMetadata('creativework.datePublished')"
2727
class="item-date card-text text-muted">

‎src/app/entity-groups/journal-entities/item-grid-elements/search-result-grid-elements/journal/journal-search-result-grid-element.component.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
</span>
2121
<div class="card-body">
2222
<ds-themed-badges *ngIf="showLabel" [object]="dso" [context]="context"></ds-themed-badges>
23-
<ds-truncatable-part [id]="dso.id" [minLines]="3" type="h4">
24-
<h4 class="card-title" [innerHTML]="dsoTitle"></h4>
23+
<ds-truncatable-part [id]="dso.id" [minLines]="3" type="h2">
24+
<h2 class="card-title" [innerHTML]="dsoTitle"></h2>
2525
</ds-truncatable-part>
2626
<p *ngIf="dso.hasMetadata('creativework.editor')"
2727
class="item-publisher card-text text-muted">

‎src/app/entity-groups/research-entities/item-grid-elements/search-result-grid-elements/org-unit/org-unit-search-result-grid-element.component.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
</span>
2121
<div class="card-body">
2222
<ds-themed-badges *ngIf="showLabel" [object]="dso" [context]="context"></ds-themed-badges>
23-
<ds-truncatable-part [id]="dso.id" [minLines]="3" type="h4">
24-
<h4 class="card-title" [innerHTML]="dsoTitle"></h4>
23+
<ds-truncatable-part [id]="dso.id" [minLines]="3" type="h2">
24+
<h2 class="card-title" [innerHTML]="dsoTitle"></h2>
2525
</ds-truncatable-part>
2626
<p *ngIf="dso.hasMetadata('organization.foundingDate')"
2727
class="item-date card-text text-muted">

‎src/app/entity-groups/research-entities/item-grid-elements/search-result-grid-elements/person/person-search-result-grid-element.component.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
</span>
2121
<div class="card-body">
2222
<ds-themed-badges *ngIf="showLabel" [object]="dso" [context]="context"></ds-themed-badges>
23-
<ds-truncatable-part [id]="dso.id" [minLines]="3" type="h4">
24-
<h4 class="card-title" [innerHTML]="dsoTitle"></h4>
23+
<ds-truncatable-part [id]="dso.id" [minLines]="3" type="h2">
24+
<h2 class="card-title" [innerHTML]="dsoTitle"></h2>
2525
</ds-truncatable-part>
2626
<p *ngIf="dso.hasMetadata('person.email')" class="item-email card-text text-muted">
2727
<ds-truncatable-part [id]="dso.id" [minLines]="1">

‎src/app/entity-groups/research-entities/item-grid-elements/search-result-grid-elements/project/project-search-result-grid-element.component.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
</span>
2121
<div class="card-body">
2222
<ds-themed-badges *ngIf="showLabel" [object]="dso" [context]="context"></ds-themed-badges>
23-
<ds-truncatable-part [id]="dso.id" [minLines]="3" type="h4">
24-
<h4 class="card-title" [innerHTML]="dsoTitle"></h4>
23+
<ds-truncatable-part [id]="dso.id" [minLines]="3" type="h2">
24+
<h2 class="card-title" [innerHTML]="dsoTitle"></h2>
2525
</ds-truncatable-part>
2626
<p *ngIf="dso.hasMetadata('dc.description')" class="item-description card-text text-muted">
2727
<ds-truncatable-part [id]="dso.id" [minLines]="3">

‎src/app/shared/object-grid/collection-grid-element/collection-grid-element.component.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
</ds-themed-thumbnail>
99
</span>
1010
<div class="card-body">
11-
<h4 class="card-title">{{ dsoNameService.getName(object) }}</h4>
11+
<h2 class="card-title">{{ dsoNameService.getName(object) }}</h2>
1212
<p *ngIf="object.shortDescription" class="card-text">{{object.shortDescription}}</p>
1313
<div *ngIf="linkType != linkTypes.None" class="text-center">
1414
<a [target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'" [attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener noreferrer' : null" [routerLink]="['/collections/', object.id]" class="lead btn btn-primary viewButton">{{ 'search.results.view-result' | translate}}</a>

‎src/app/shared/object-grid/community-grid-element/community-grid-element.component.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
</ds-themed-thumbnail>
99
</span>
1010
<div class="card-body">
11-
<h4 class="card-title">{{ dsoNameService.getName(object) }}</h4>
11+
<h2 class="card-title">{{ dsoNameService.getName(object) }}</h2>
1212
<p *ngIf="object.shortDescription" class="card-text">{{object.shortDescription}}</p>
1313
<div *ngIf="linkType != linkTypes.None" class="text-center">
1414
<a [target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'" [attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener noreferrer' : null" [routerLink]="['/communities/', object.id]" class="lead btn btn-primary viewButton">{{ 'search.results.view-result' | translate}}</a>

‎src/app/shared/object-grid/object-grid.component.scss‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55
margin-top: var(--ds-wrapper-grid-spacing);
66
margin-bottom: var(--ds-wrapper-grid-spacing);
77

8+
h2.card-title {
9+
font-size: 1.5rem;
10+
}
11+
812
div.thumbnail > .thumbnail-content {
913
height: var(--ds-card-thumbnail-height);
1014
width: 100%;

‎src/app/shared/object-grid/search-result-grid-element/collection-search-result/collection-search-result-grid-element.component.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
</span>
1010
<div class="card-body">
1111
<ds-themed-badges *ngIf="showLabel" [object]="dso" [context]="context"></ds-themed-badges>
12-
<h4 class="card-title">{{ dsoNameService.getName(dso) }}</h4>
12+
<h2 class="card-title">{{ dsoNameService.getName(dso) }}</h2>
1313
<p *ngIf="dso.shortDescription" class="card-text">{{dso.shortDescription}}</p>
1414
<div *ngIf="linkType != linkTypes.None" class="text-center">
1515
<a [target]="(linkType == linkTypes.ExternalLink) ? '_blank' : '_self'" [attr.rel]="(linkType == linkTypes.ExternalLink) ? 'noopener noreferrer' : null" [routerLink]="['/collections/', dso.id]" class="lead btn btn-primary viewButton">{{ 'search.results.view-result' | translate}}</a>

0 commit comments

Comments
 (0)