Release 2.4.1 (#293)

* Removes issue done section and unnecessary green checkboxes for invalid address

Fixes #183

Also fixes alignment of the update location button in the issue activity, which was previously overlapping the no calls message.

* Update version number for release

* Remove Firebase Analytics and increment version

* Fix crash in Settings when reminders are enabled but notifications are not enabled

registerForActivityResult must be called from onCreate or we get a crash. Fixes the crash and tests that the notifications dialog is shown. Leaves as TODO to tell the user they must go into settings to turn notifications on after notifications are disabled the first time. This could do with some polish but fixes the crash in #211

* Add string for remdiners setting when notifications disabled, rev version for release

* Increment version for release

* Whitespace

* Fix voicemail/contact string swap in rep call activity, rev version

* Update version number for release

* Shorten snackbar string & rev version

* Show long snackbar string, more lines, re-add disclosure, rev version

* Disable state issues and uprev version for release

* Update version for release

* Fix crash due to private constructor, bump version

Author: dektar

5calls/app/build.gradle

@@ -10,8 +10,8 @@ android {
         applicationId "org.a5calls.android.a5calls"
         minSdkVersion 23
         targetSdkVersion 36
-        versionCode 78
-        versionName '2.4.0'
+        versionCode 80
+        versionName '2.4.1'
         testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
         signingConfig signingConfigs.debug
     }

5calls/app/src/main/java/org/a5calls/android/a5calls/controller/TutorialActivity.java

@@ -145,7 +145,9 @@ public static StaticTutorialPageFragment newInstance(int layoutId) {
             return fragment;
         }
 
-        private StaticTutorialPageFragment() {}
+        public StaticTutorialPageFragment() {
+            // Required empty public constructor.
+        }
 
         @Nullable
         @Override

5calls/app/src/main/java/org/a5calls/android/a5calls/net/FiveCallsApi.java

@@ -167,7 +167,7 @@ public void getIssues() {
         if (!TextUtils.isEmpty(state)) {
             urlBuilder.appendQueryParameter(GET_ISSUES_REQUEST_PARAM_STATE, state);
         }
-        
+
         String url = urlBuilder.build().toString();
         buildIssuesRequest(url, mIssuesRequestListeners);
     }