Added voter registration button in "about" page - #316
Conversation
nickoneill
left a comment
nickoneill
left a comment
There was a problem hiding this comment.
Thanks @brianjcoan! One nit about which link we're using for verify going forward. Otherwise lgtm, I'll defer to @dektar on the actual code
| <string name="check_your_registration_button">Check your registration</string> | ||
|
|
||
| <!-- URL for the 5 Calls Why Calling Works page [CHAR_LIMIT=NONE] --> | ||
| <string name="check_your_registration_url" translatable="false">https://www.feelgoodimpact.org/partners/5calls-verify?utm_source=partner&utm_medium=**android**&utm_campaign=5calls&utm_term=verify&utm_content=5calls_lp_1</string> |
brianjcoan
changed the title
dektar
left a comment
dektar
left a comment
There was a problem hiding this comment.
Thanks for adding this link! Some comments below.
| @@ -1,4 +1,4 @@ | |||
| <resources xmlns:xliff="http://schemas.android.com/tools"> | |||
| <resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2" xmlns:tools="http://schemas.android.com/tools"> | |||
There was a problem hiding this comment.
What's the value of urn:oasis... ?
There was a problem hiding this comment.
I'll get rid of this, it's now in the gradle upgrade PR
|
|
||
| <!-- Message to the user when no location is set, prompting them to set a location. [CHAR_LIMIT=NONE] --> | ||
| <string name="error_no_location_set">Establece tu ubicación para encontrar a tus representantes.</string> | ||
| <string name="error_no_location_set">Establezca su ubicación para encontrar a sus representantes.</string> |
There was a problem hiding this comment.
there's a lot of unrelated changes to strings.xml that aren't to do with the voter registration button. could we do those in a separate PR? And are they coming from AI or from a fluent Spanish speaker? A lot of our strings were translated by humans so I wouldn't want to switch to AI strings.
There was a problem hiding this comment.
as mentioned in the PR description i'm not a native speaker, i just saw a mix of formal and informal and thought to clean that up. but i'll get rid of these changes
| <!-- Description of a setting to show an example call in the calls list [CHAR_LIMIT=NONE]--> | ||
| <string name="settings_reshow_demo_description">Show an example issue in the list with hints about how to use 5 Calls.</string> | ||
|
|
||
| <string name="check_your_registration_prompt">Check your registration</string> |
There was a problem hiding this comment.
please add comments about these new strings: where they are shown, info about the char limit, like what we've done with all the others here.
3 participants
What type of PR is this? (check all applicable)
Description
Per #150, added button to check voter registration on Feel Good Impact.
Also found a mix of informal and formal Spanish in the strings file, tried to change all to formal Spanish
(but I'm not a native speaker, so not claiming its the best translation).
Related Issues
Were the changes tested?
have not been included