Merge pull request #15 from 6boris/dev

fix: resolve all forge lint and fmt issues across the codebase

Author: 6boris

.solhint.json

@@ -1,6 +1,7 @@
 {
   "extends": "solhint:recommended",
   "rules": {
+    "use-natspec": "off",
     "code-complexity": ["warn", 10],
     "compiler-version": ["error", ">=0.8.0"],
     "func-name-mixedcase": "off",

.solhintignore

@@ -1,3 +1,8 @@
 foundry/lib
 dependencies
 node_modules
+contracts/CTF/Damn-Vulnerable-DeFi
+contracts/CTF/ONLYPWNER
+foundry/test/CTF/Damn-Vulnerable-DeFi
+foundry/test/CTF/ONLYPWNER
+foundry/script/CTF/ONLYPWNER

contracts/CTF/Damn-Vulnerable-DeFi/01.Unstoppable.sol

@@ -1,3 +1,4 @@
+// forge-lint: disable-start
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.0;
 

contracts/CTF/Damn-Vulnerable-DeFi/02.Naive-Receiver.sol

@@ -1,3 +1,4 @@
+// forge-lint: disable-start
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.0;
 

contracts/CTF/Damn-Vulnerable-DeFi/03.Truster.sol

@@ -1,3 +1,4 @@
+// forge-lint: disable-start
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.0;
 

contracts/CTF/Damn-Vulnerable-DeFi/04.Side-Entrance.sol

@@ -1,3 +1,4 @@
+// forge-lint: disable-start
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.0;
 

contracts/CTF/Damn-Vulnerable-DeFi/05.The-Rewarder.sol

@@ -1,3 +1,4 @@
+// forge-lint: disable-start
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.0;
 
@@ -178,10 +179,8 @@ contract TheRewarderPool {
     }
 
     function _hasRetrievedReward(address account) private view returns (bool) {
-        return (
-            lastRewardTimestamps[account] >= lastRecordedSnapshotTimestamp
-                && lastRewardTimestamps[account] <= lastRecordedSnapshotTimestamp + REWARDS_ROUND_MIN_DURATION
-        );
+        return (lastRewardTimestamps[account] >= lastRecordedSnapshotTimestamp
+                && lastRewardTimestamps[account] <= lastRecordedSnapshotTimestamp + REWARDS_ROUND_MIN_DURATION);
     }
 
     function isNewRewardsRound() public view returns (bool) {

contracts/CTF/Damn-Vulnerable-DeFi/06.Selfie.sol

@@ -1,3 +1,4 @@
+// forge-lint: disable-start
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.0;
 
@@ -132,11 +133,7 @@ contract SimpleGovernance is ISimpleGovernance {
         actionId = _actionCounter;
 
         _actions[actionId] = GovernanceAction({
-            target: target,
-            value: value,
-            proposedAt: uint64(block.timestamp),
-            executedAt: 0,
-            data: data
+            target: target, value: value, proposedAt: uint64(block.timestamp), executedAt: 0, data: data
         });
 
         unchecked {

contracts/CTF/Damn-Vulnerable-DeFi/07.Compromised.sol

@@ -1,3 +1,4 @@
+// forge-lint: disable-start
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.0;
 

contracts/CTF/Damn-Vulnerable-DeFi/08.Puppet.sol

@@ -1,3 +1,4 @@
+// forge-lint: disable-start
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.0;
 
@@ -38,13 +39,7 @@ interface IUniswapV1Exchange {
     function getTokenToEthInputPrice(uint256 tokens_sold) external view returns (uint256 eth_bought);
     function getTokenToEthOutputPrice(uint256 eth_bought) external view returns (uint256 tokens_sold);
     // Trade ETH to ERC20
-    function ethToTokenSwapInput(
-        uint256 min_tokens,
-        uint256 deadline
-    )
-        external
-        payable
-        returns (uint256 tokens_bought);
+    function ethToTokenSwapInput(uint256 min_tokens, uint256 deadline) external payable returns (uint256 tokens_bought);
     function ethToTokenTransferInput(
         uint256 min_tokens,
         uint256 deadline,
@@ -53,13 +48,7 @@ interface IUniswapV1Exchange {
         external
         payable
         returns (uint256 tokens_bought);
-    function ethToTokenSwapOutput(
-        uint256 tokens_bought,
-        uint256 deadline
-    )
-        external
-        payable
-        returns (uint256 eth_sold);
+    function ethToTokenSwapOutput(uint256 tokens_bought, uint256 deadline) external payable returns (uint256 eth_sold);
     function ethToTokenTransferOutput(
         uint256 tokens_bought,
         uint256 deadline,