Conversation
- Fix forge fmt formatting in 8 files (auto-formatted) - Add forge-lint: disable-start to 52 third-party CTF files (DVDeFi, ONLYPWNER, Ethernaut, IPancakeRouter, Platypus) - Fix BatchTransfer.sol: rename functions to mixedCase, rename toTokenIDList to toTokenIdList - Fix BatchTransfer.t.sol: remove unused import, use named struct fields, add require on transfer - Fix wkeyDAO.sol: constants to SCREAMING_SNAKE_CASE, fix function names, add require on transfer - Configure .solhintignore to exclude third-party CTF directories - Add [lint] ignore config in foundry.toml for DVDeFi and ONLYPWNER Result: forge lint 288→0, forge fmt clean, solhint 374→120, all 24 tests passing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result: forge lint 288→0, forge fmt clean, solhint 374→120, all 24 tests passing.