Add Fishel Lab script commands for Zaber LSQ, Zaber NMS, and PI E-709 motors - #169
Open
teaguesvendsen287 wants to merge 2 commits into
Open
Add Fishel Lab script commands for Zaber LSQ, Zaber NMS, and PI E-709 motors#169teaguesvendsen287 wants to merge 2 commits into
teaguesvendsen287 wants to merge 2 commits into
Conversation
teaguesvendsen287
commented
May 21, 2026
teaguesvendsen287
commented
Collaborator
- Add 7 custom script Command dataclasses (LinearMoveCommand, LinearJogCommand, LinearHomeCommand, RotaryMoveCommand, RotaryJogCommand, FocusMoveCommand, FocusJogCommand), each with a wait_until_done field
- Add ScriptMoveErrorCommand for reporting motor failures during script execution
- Implement wait_until_done flow: motor managers poll hardware in fetch() and send UpdateWaitingCommand back to ScriptManager once movement completes
- Add register_script_command decorators on all new handlers so they are discoverable by ScriptRegistry
- Create example script (examples/fishel_lab_scripts/) showing usage of all 7 commands with wait_until_done
… motors - Add 7 custom script Command dataclasses (LinearMoveCommand, LinearJogCommand, LinearHomeCommand, RotaryMoveCommand, RotaryJogCommand, FocusMoveCommand, FocusJogCommand), each with a wait_until_done field - Add ScriptMoveErrorCommand for reporting motor failures during script execution - Implement wait_until_done flow: motor managers poll hardware in fetch() and send UpdateWaitingCommand back to ScriptManager once movement completes - Add register_script_command decorators on all new handlers so they are discoverable by ScriptRegistry - Create example script (examples/fishel_lab_scripts/) showing usage of all 7 commands with wait_until_done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.