Support 2D transposed shape alignment in model_creation_utils - #5071
Open
suhithr wants to merge 3 commits into
Open
Support 2D transposed shape alignment in model_creation_utils#5071suhithr wants to merge 3 commits into
suhithr wants to merge 3 commits into
Conversation
When restoring scanned MoE checkpoints (such as DeepSeek V3), router gate bias (e.g. MoEBiasVar) may be stored on disk with shape (num_experts, num_moe_layers) due to converter scan-axis stacking, whereas Flax NNX defines the parameter as (num_moe_layers, num_experts). Handle 2D transposed dimensions in _align_checkpoint_to_model_shapes() by transposing the checkpoint array to match target model shapes.
There was a problem hiding this comment.
Code Review
This pull request adds support for aligning transposed 2D checkpoint arrays to the model shape in _align_checkpoint_to_model_shapes and includes corresponding unit tests. The reviewer suggested simplifying the transposition logic by removing a redundant shape check, as transposing a 2D array with reversed dimensions mathematically guarantees it will match the target model shape.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
suhithr
marked this pull request as ready for review
August 31, 2026 16:42
suhithr
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
shuningjin,
vipannalla and
xibinliu
as code owners
August 31, 2026 16:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When restoring scanned MoE checkpoints (such as DeepSeek V3), router gate bias (e.g. MoEBiasVar) may be stored on disk with shape (num_experts, num_moe_layers) due to converter scan-axis stacking, whereas Flax NNX defines the parameter as (num_moe_layers, num_experts).
Handle 2D transposed dimensions in _align_checkpoint_to_model_shapes() by transposing the checkpoint array to match target model shapes.
FIXES: b/553744097
Tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.