Skip to content

Upgrade drjax to 0.2.1 - #5075

Open
khatwanimohit wants to merge 1 commit into
mainfrom
upgrade-drjax-0.2.1
Open

Upgrade drjax to 0.2.1#5075
khatwanimohit wants to merge 1 commit into
mainfrom
upgrade-drjax-0.2.1

Conversation

@khatwanimohit

@khatwanimohit khatwanimohit commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Description

Bump the drjax floor to the latest PyPI release

Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.

Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.

Tests

CI

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the drjax dependency version constraint to >=0.2.1 across multiple requirements files, including base, generated, and TPU-specific requirements. There are no review comments, and I have no feedback to provide.

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@khatwanimohit
khatwanimohit force-pushed the upgrade-drjax-0.2.1 branch 2 times, most recently from a68877c to cd579d3 Compare August 31, 2026 22:30
Bump the drjax floor to the latest PyPI release in the base requirements
and regenerate the generated_requirements/ locks with the seed-env flow
from docs/development/update_dependencies.md. Regenerating re-resolves
each lock in full, so the locks also pick up unrelated version bumps.

Pins llguidance<1.8.0 in the post-training base requirements: seed-env
cannot resolve that lock otherwise, since vllm's tpu.txt constrains
llguidance to <1.8.0 while the previously unpinned entry resolved to
>=1.8.0. That break is independent of drjax and reproduces on main.

Regenerating also moves tokamax to 0.0.13, which imports xprof at module
scope. xprof is filtered out of the decoupled requirements because it
depends on gcsfs and google-cloud-storage, and maxtext imports tokamax
from megablox, so every decoupled test that reaches maxtext.layers.moe
stopped collecting, and letting xprof back in would make the Google Cloud
clients importable in the one environment meant to prove they are absent.

Pin tokamax==0.0.12 for the decoupled requirements only, via a new
PINNED_PACKAGES map in generate_decoupled_requirements.py. 0.0.12 is the
last release that does not need xprof, so that environment stays free of
the Cloud clients while the hardware locks keep tokamax 0.0.13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants