Skip to content

Commit 0fa4af8

Browse files
Let the C++ build fire again (#775) (#1015)
CPPBuild.yml's path filters read "./Sources/Wrappers/AngouriMath.CPP.*/**". A path filter is a glob matched against paths relative to the repository root, so the leading "./" matches nothing: from the commit that added the filter (f51c7e0, 2026-01-02) the workflow has run zero times, while three commits touching exactly those directories were merged -- 4eb9445, dc349c3 and f4807c4. The same defect silenced Benchmark.yml for ninety-eight PRs, which is why the comment at the top of that file exists; this is the other half of the same commit. The kernel is added to the list because the exported native library is compiled from it, so a kernel change is what can break this build; and the workflow file itself is added so that a change to these filters demonstrates itself. Claude-Session: https://claude.ai/code/session_011emtnRT6EWTrxXNtqDVK3e Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 8f71597 commit 0fa4af8

1 file changed

Lines changed: 16 additions & 2 deletions

File tree

‎.github/workflows/CPPBuild.yml‎

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,30 @@
11
name: 'C++ Build'
22

3+
# A path filter is a glob matched against paths relative to the repository root, and the leading
4+
# "./" these patterns carried matches nothing: from the day the filter was added (f51c7e03,
5+
# 2026-01-02) this workflow ran zero times, while three commits touching the very directories it
6+
# names were merged. It is the same defect that silenced Benchmark.yml for ninety-eight PRs --
7+
# see the comment at the top of that file, and
8+
# https://github.com/asc-community/AngouriMath/issues/775.
9+
#
10+
# The kernel is in the list because the exported native library is compiled from it, so a kernel
11+
# change is exactly what can break this build; and this file is in the list so that a change to
12+
# these filters demonstrates itself rather than being reasoned about.
313
on:
414
push:
515
branches:
616
- master
717
paths:
8-
- "./Sources/Wrappers/AngouriMath.CPP.*/**"
18+
- "Sources/Wrappers/AngouriMath.CPP.*/**"
19+
- "Sources/AngouriMath/**"
20+
- ".github/workflows/CPPBuild.yml"
921
pull_request:
1022
branches:
1123
- '*'
1224
paths:
13-
- "./Sources/Wrappers/AngouriMath.CPP.*/**"
25+
- "Sources/Wrappers/AngouriMath.CPP.*/**"
26+
- "Sources/AngouriMath/**"
27+
- ".github/workflows/CPPBuild.yml"
1428
workflow_dispatch:
1529

1630
jobs:

0 commit comments

Comments
 (0)