Repository navigation
Commit 59db007
authored
Build the samples against the source, not a package from two majors ago (#846)
SampleNet5 referenced AngouriMath 1.3.0 and FSharpSample referenced
AngouriMath.FSharp 1.3.0, while every other project in the solution uses a
ProjectReference. The pin demonstrated neither the current source nor the
current release, and kept the samples out of every tree-wide change -- the
Latexise rename swept the repository and skipped them silently.
Running them, rather than only building them, showed both had been broken
against the current release since January: they call integral(f, x, 1), which
1.3.0 accepted and 1.4.0 began rejecting. Measured across three published
versions. They now use the two-argument form, which is what 1.3.0 turned the
three-argument one into anyway, so they are unchanged in meaning.
The arity question itself is
#847.1 parent 59947e3 commit 59db007
4 files changed
Lines changed: 13 additions & 13 deletions
File tree
- Sources/Samples
- FSharpSample
- SampleNet5
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
0 commit comments