Skip to content

Commit 59db007

Browse files
Build the samples against the source, not a package from two majors ago (#846)
SampleNet5 referenced AngouriMath 1.3.0 and FSharpSample referenced AngouriMath.FSharp 1.3.0, while every other project in the solution uses a ProjectReference. The pin demonstrated neither the current source nor the current release, and kept the samples out of every tree-wide change -- the Latexise rename swept the repository and skipped them silently. Running them, rather than only building them, showed both had been broken against the current release since January: they call integral(f, x, 1), which 1.3.0 accepted and 1.4.0 began rejecting. Measured across three published versions. They now use the two-argument form, which is what 1.3.0 turned the three-argument one into anyway, so they are unchanged in meaning. The arity question itself is #847.
1 parent 59947e3 commit 59db007

4 files changed

Lines changed: 13 additions & 13 deletions

File tree

‎Sources/Samples/FSharpSample/FSharpSample.fsproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
</ItemGroup>
1111

1212
<ItemGroup>
13-
<PackageReference Include="AngouriMath.FSharp" Version="1.3.0" />
13+
<ProjectReference Include="..\..\Wrappers\AngouriMath.FSharp\AngouriMath.FSharp.fsproj" />
1414
</ItemGroup>
1515

1616
</Project>

‎Sources/Samples/FSharpSample/Program.fs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,4 @@ printfn "%O" (``lim x->0`` "sin(a x) / x")
4343
printfn "%O" (limit "x" 0 "sin(a x) / x")
4444

4545
// LaTeX
46-
printfn "%O" (latex "x / e + alpha + sqrt(x) + integral(y + 3, y, 1)")
46+
printfn "%O" (latex "x / e + alpha + sqrt(x) + integral(y + 3, y)")

‎Sources/Samples/SampleNet5/Program.cs‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,24 +38,24 @@
3838
// Solve a complicated statement
3939
WriteLine("(x - 2)(x - 3) = 0 and (x - 1)(x - 2) = 0".Solve("x").InnerSimplified.Stringize());
4040
WriteLine("sin(a x)2 + c sin(2 a x) = c".Solve("x"));
41-
WriteLine("(x - 6)(x + 9) >= 0".Solve("x").Latexise());
41+
WriteLine("(x - 6)(x + 9) >= 0".Solve("x").Latexize());
4242
WriteLine();
4343

4444
// Work with sets
45-
WriteLine("{ 1, 2 }".Latexise());
46-
WriteLine("[3; +oo)".Latexise());
47-
WriteLine("RR".Latexise());
48-
WriteLine("{ x : x8 + a x < 0 }".Latexise());
49-
WriteLine(@"A \/ B".Latexise());
50-
WriteLine(@"A /\ B".Latexise());
51-
WriteLine(@"A \ B".Latexise());
45+
WriteLine("{ 1, 2 }".Latexize());
46+
WriteLine("[3; +oo)".Latexize());
47+
WriteLine("RR".Latexize());
48+
WriteLine("{ x : x8 + a x < 0 }".Latexize());
49+
WriteLine(@"A \/ B".Latexize());
50+
WriteLine(@"A /\ B".Latexize());
51+
WriteLine(@"A \ B".Latexize());
5252
WriteLine(@"{ 1, 2, 3 } \/ { 3, 5 }".Simplify());
5353
WriteLine(@"[a; b) \/ { b }".Simplify());
5454
WriteLine();
5555

5656
// Differentiate, integrate, find limits
5757
WriteLine("x2 + a x".Differentiate("x").InnerSimplified);
58-
WriteLine("x2 + a x".Integrate("x").InnerSimplified.Latexise());
58+
WriteLine("x2 + a x".Integrate("x").InnerSimplified.Latexize());
5959
WriteLine("(a x2 + b x) / (e x - h x2 - 3)".Limit("x", "+oo").InnerSimplified);
6060
WriteLine();
6161

@@ -66,4 +66,4 @@
6666
WriteLine();
6767

6868
// LaTeX
69-
WriteLine("x ^ y + sqrt(x) + integral(sqrt(x) / a, x, 1) + derivative(sqrt(x) / a, x, 1) + limit(sqrt(x) / a, x, +oo)".Latexise());
69+
WriteLine("x ^ y + sqrt(x) + integral(sqrt(x) / a, x) + derivative(sqrt(x) / a, x, 1) + limit(sqrt(x) / a, x, +oo)".Latexize());

‎Sources/Samples/SampleNet5/SampleNet5.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
</PropertyGroup>
77

88
<ItemGroup>
9-
<PackageReference Include="AngouriMath" Version="1.3.0" />
9+
<ProjectReference Include="..\..\AngouriMath\AngouriMath.csproj" />
1010
</ItemGroup>
1111

1212
</Project>

0 commit comments

Comments
 (0)