Skip to content

Commit 5bdd2c6

Browse files
Build the terminal before merging, not at release time (#1024)
AngouriMath.Terminal is one of the four published packages: Nuget.yml packs it as a dotnet tool with the command name amcli and pushes it on release. No pre-merge job compiled it. The only job that builds it is TerminalNightly.yml, which fires on push to master behind a path filter on Sources/Terminal/VERSION, so a change that breaks the terminal is not seen until somebody bumps that file or cuts a release -- and a release is the worst moment to find out. This is the same gap the samples had, for the same reason, and the comment above the samples step records what that one cost. Measured on this branch: the project builds clean from a fresh worktree, 0 errors, in 24 seconds. It does emit four NU1608 warnings -- FSharp.Compiler.Service 43.9.300 constrains FSharp.Core to 9.0.300 and 10.1.302 resolves -- which are pre-existing and not treated as errors here; they are now at least visible on every pull request rather than once a month.
1 parent 5e2a003 commit 5bdd2c6

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

‎.github/workflows/EverythingBuild.yml‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,14 @@ jobs:
3232
- name: Build Interactive
3333
run: dotnet build Sources/Wrappers/AngouriMath.Interactive/AngouriMath.Interactive.fsproj
3434

35+
# AngouriMath.Terminal is a published package -- Nuget.yml packs and pushes it as a
36+
# dotnet tool -- and no pre-merge job built it. TerminalNightly.yml is the only job
37+
# that does, and it fires on push to master behind a path filter on
38+
# Sources/Terminal/VERSION/**, so a change that breaks the terminal is not seen until
39+
# somebody bumps that file or cuts a release.
40+
- name: Build Terminal
41+
run: dotnet build Sources/Terminal/AngouriMath.Terminal/AngouriMath.Terminal.fsproj
42+
3543
- name: Build Analyzers
3644
run: dotnet build Sources/Analyzers/Analyzers/Analyzers.csproj
3745

0 commit comments

Comments
 (0)