Repository navigation
Commit 5bdd2c6
authored
Build the terminal before merging, not at release time (#1024)
AngouriMath.Terminal is one of the four published packages: Nuget.yml packs it
as a dotnet tool with the command name amcli and pushes it on release. No
pre-merge job compiled it. The only job that builds it is TerminalNightly.yml,
which fires on push to master behind a path filter on Sources/Terminal/VERSION,
so a change that breaks the terminal is not seen until somebody bumps that file
or cuts a release -- and a release is the worst moment to find out.
This is the same gap the samples had, for the same reason, and the comment
above the samples step records what that one cost.
Measured on this branch: the project builds clean from a fresh worktree, 0
errors, in 24 seconds. It does emit four NU1608 warnings -- FSharp.Compiler.Service
43.9.300 constrains FSharp.Core to 9.0.300 and 10.1.302 resolves -- which are
pre-existing and not treated as errors here; they are now at least visible on
every pull request rather than once a month.1 parent 5e2a003 commit 5bdd2c6
1 file changed
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
35 | 43 | | |
36 | 44 | | |
37 | 45 | | |
| |||
0 commit comments