Repository navigation
Commit 64f144b
Remember a decline a sum over roots would answer as one, so a later question still gets the second pass (#2036)
The integrator keeps the answers it found per thread, across top-level
questions, for as long as the settings hold. A rational function whose
residues want a sum over roots is declined in the first pass, which sets
ASumOverRootsWouldAnswer, and the second pass answers it; afterwards only the
top-level question's entry was replaced with that answer. The first pass's
declines of its sub-questions stayed in the memo as plain declines, and a
later question that asked one of them got it from the memo, so the rule never
ran to set the flag and no second pass ran: the question was declined.
Integrating (1 + x^4)/(1 - x^4 + x^8) and then
(1 + (1 + sqrt(3)) x^4)/(1 - x^4 + x^8) on one thread declined the second in
63 ms, which answers alone. Rubi's 1.2.3.3:53 was counted unsolved in the
harness's family-1 sample for exactly this reason: the worker integrates the
file's rows in order, and row 33 comes first. Bisected over the 1,202 rows
before it to that one.
The memo now records, with a decline, whether a sum over roots was wanted in
computing it, and a hit on such a decline sets the flag again. Whether one was
wanted is read from a count of the flag's raises around the computation; the
flag itself is still one per top-level question, which the rules that read it
mid-computation rely on. 2.5.0 declines both integrals in either order, having
no sums over roots, so no released answer changes.
Part of #233.
Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>1 parent 99fca7a commit 64f144b
2 files changed
Lines changed: 92 additions & 7 deletions
File tree
- Sources
- AngouriMath/Functions/Continuous/Integration
- Tests/UnitTests/Calculus
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
290 | 290 | | |
291 | 291 | | |
292 | 292 | | |
293 | | - | |
| 293 | + | |
294 | 294 | | |
295 | 295 | | |
296 | 296 | | |
| |||
539 | 539 | | |
540 | 540 | | |
541 | 541 | | |
542 | | - | |
| 542 | + | |
543 | 543 | | |
544 | 544 | | |
545 | 545 | | |
| |||
553 | 553 | | |
554 | 554 | | |
555 | 555 | | |
556 | | - | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
557 | 575 | | |
558 | 576 | | |
559 | 577 | | |
| |||
606 | 624 | | |
607 | 625 | | |
608 | 626 | | |
609 | | - | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
610 | 637 | | |
611 | | - | |
612 | | - | |
| 638 | + | |
| 639 | + | |
613 | 640 | | |
614 | 641 | | |
615 | 642 | | |
| |||
619 | 646 | | |
620 | 647 | | |
621 | 648 | | |
| 649 | + | |
622 | 650 | | |
623 | 651 | | |
624 | 652 | | |
| |||
648 | 676 | | |
649 | 677 | | |
650 | 678 | | |
651 | | - | |
| 679 | + | |
652 | 680 | | |
653 | 681 | | |
654 | 682 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
0 commit comments