Repository navigation
Commit 9444691
authored
Refuse the arc- spellings of the inverse hyperbolic functions (#687)
arcsinh(x) parsed as arcsinh * x -- a product of an undeclared variable and x --
and said nothing about it. The same for arccosh, arctanh, arccotanh, arcsech and
arccosech.
Rewritten from taking those spellings as synonyms to refusing them, following
Happypig375 on the pull request: the inverse hyperbolic functions are area
functions, not arc functions, so arcsinh is not another name for arsinh, it is
not a name for anything. Each is now an UnrecognizedFunctionParseException that
says so and names the spellings that do work:
there is no function arcsinh: the inverse hyperbolic functions are area
functions, not arc functions, so the inverse hyperbolic sine is arsinh,
asinh or arsh
Nothing else changes. The twenty-one spellings the grammar already accepted
still parse, arcsin and its five relatives are correct and untouched, and a name
that merely begins the same way -- arcs(x), arcsinhh(x) -- is still the product
it was.
Done by changing AngouriMath.g and regenerating with the repository's own
antlr-4.13.1-complete.jar and post-processor, as Docs/Contributing/ImproveParser.md
sets out. Four spellings that already parsed but were untested are added to
TestHyperbolic while passing. 4036 tests, 127 F#.1 parent 4756cf9 commit 9444691
10 files changed
Lines changed: 945 additions & 693 deletions
File tree
- Sources
- AngouriMath/Core
- Antlr
- Exceptions
- Tests/UnitTests/Convenience
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
324 | 324 | | |
325 | 325 | | |
326 | 326 | | |
| 327 | + | |
327 | 328 | | |
328 | 329 | | |
329 | 330 | | |
330 | 331 | | |
| 332 | + | |
331 | 333 | | |
332 | 334 | | |
333 | 335 | | |
334 | 336 | | |
| 337 | + | |
335 | 338 | | |
336 | 339 | | |
337 | 340 | | |
338 | 341 | | |
339 | 342 | | |
340 | 343 | | |
| 344 | + | |
341 | 345 | | |
342 | 346 | | |
343 | 347 | | |
344 | 348 | | |
| 349 | + | |
345 | 350 | | |
346 | 351 | | |
347 | 352 | | |
348 | 353 | | |
| 354 | + | |
349 | 355 | | |
350 | 356 | | |
351 | 357 | | |
| |||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
129 | 135 | | |
130 | 136 | | |
131 | 137 | | |
| |||
214 | 220 | | |
215 | 221 | | |
216 | 222 | | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
0 commit comments