Repository navigation
Commit f4807c4
Let the SDK pick the ILCompiler version, fixing the native build on master (#674)
* Let the SDK pick the ILCompiler version, fixing the native build
The C++ Test and C++ Build workflows have failed on master since around February:
Microsoft.NETCore.Native.Publish.targets(70,5): error : The PrivateSdkAssemblies
ItemGroup is required for _ComputeAssembliesToCompileToNative
The exporting project pins Microsoft.DotNet.ILCompiler to 10.0.1 while the workflows
install the current 10.x SDK, and with PublishAot the SDK brings its own matching
ILCompiler. The two disagree, and the build stops. The toolchain says as much in a
warning immediately above the error: "Delete explicit 'Microsoft.DotNet.ILCompiler'
package reference in your project file to avoid versioning problems."
Removing the reference is the whole change. The SDK then resolves 10.0.10 here,
matching itself, and `dotnet publish -p:NativeLib=Shared -p:SelfContained=true
-p:PublishAot=true -r linux-x64 -c release` completes with no errors and no warnings,
producing AngouriMath.CPP.Exporting.so.
Nothing else references the package; the pin was the only thing holding the version
back.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* Refresh the package index before installing, in the C++ workflows
The ubuntu leg of both C++ workflows dies before it reaches the build:
E: Failed to fetch .../libkrb5-dev_1.20.1-6ubuntu2.6_amd64.deb 404 Not Found
apt-get install is called without apt-get update first, so it asks the mirror for
whatever versions the runner image happened to be built with. Once those are
superseded they are gone from the pool and every one of them 404s.
Added the update, and -y so the install is not waiting on a prompt. The two packages
go in one call rather than two, which is only tidier.
This is a second, independent break from the ILCompiler pin in the previous commit.
The matrix is fail-fast, so whichever leg fell over first hid the other: the run I
first read failed on macOS with the ILCompiler error, and the run on this branch
failed on ubuntu here, before the build could be reached at all.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>1 parent 8b33aad commit f4807c4
3 files changed
Lines changed: 4 additions & 5 deletions
File tree
- .github/workflows
- Sources/Wrappers/AngouriMath.CPP.Exporting
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
49 | | - | |
| 48 | + | |
| 49 | + | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
| 40 | + | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | 22 | | |
24 | 23 | | |
25 | 24 | | |
0 commit comments