Repository navigation
Pin seven open issues that no longer reproduce (#263, #347, #362, #424, #415, #550, #164) - #666
Merged
Happypig375 merged 1 commit intoAug 3, 2026
Conversation
Each of these is open in the tracker and works today. Nothing here is a fix; the tests exist so the issues can be closed without leaving whatever closed them unprotected. Every case is the reporter's own, taken from the issue. #263 InnerSimplify never returned on (x^15 - 3^15 - 15*3^14*(x-3))/(x-3)^2 #347 taking a limit of `a and x` overflowed the stack #362 (-1/2d-3/2d)t simplified to (-3/2*d - d/2)*t rather than -2*d*t #424 Piecewise was to become compileable #415 interval intersection and union were to be simplified #550 the reporter's small linear system did not solve #164 (x+1)^2*(x+2-1)^2 was reported as leaving sixteen uncollected terms The two that used to hang assert termination inside a bounded wait rather than a duration, so they cannot go flaky on a slow machine and a regression fails the run instead of hanging it. #550 is checked by substituting the solution back, so it does not depend on the form the solver returns. #550's 25x26 system is a question of scale and is left open at #608. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 3, 2026
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #666 +/- ##
==========================================
- Coverage 80.99% 79.43% -1.56%
==========================================
Files 155 155
Lines 13687 12294 -1393
Branches 1957 1981 +24
==========================================
- Hits 11086 9766 -1320
+ Misses 1990 1941 -49
+ Partials 611 587 -24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Aug 3, 2026
Happypig375
pushed a commit
that referenced
this pull request
Aug 4, 2026
…ests (#677) Following up on the review of #666, where three of the tests I added were pinning something other than what the issue was about. #415. The screenshot in the issue is (-1; 1) /\ ((-(sqrt(33) + 3) / 6; (sqrt(33) - 3) / 6) \/ (1; +oo)) and it came back exactly as written. Two things were missing, and both are here: - An intersection did not distribute over a union, so nothing could be done with the right-hand side however simple each piece was. - IntersectIntervalAndInterval gave up unless every endpoint was a bare Real node. (sqrt(33) - 3) / 6 is a division, so it never was one. Endpoints are compared by what they evaluate to now, while the bounds of the answer are taken from the original expressions, so the result stays exact rather than becoming a hundred decimal places. It gives (-1; (sqrt(33) - 3) / 6). #424 was tested with `provided`, which is a Providedf. The issue is about the Piecewise node, which is a different one, so the test was not testing the issue. Rewritten with piecewise(), including a three-branch case to check the branches are taken in order. It passes -- the feature does work, my test simply did not exercise it. #263 asserted only that the limit came back. The limit is what the expression was written for, so its value is asserted: 167403915. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven issues that are open in the tracker but do not reproduce on current
master.This PR contains no fix — only tests. Each pins behaviour that already works, so
the issues can be closed without leaving whatever closed them unprotected. Every case
is the reporter's own, copied from the issue.
InnerSimplifyhangs on(x^15 - 3^15 - 15·3^14·(x-3))/(x-3)^2"a and x".Limit("x", "+oo")(-1/2d-3/2d)t→(-3/2*d - d/2)*t(-2) * d * tPiecewiseshould be compileableCompile<double, double>works[1;5] /\ [3;8]→[3;5],\/→[1;8](x+1)^2*(x+2-1)^2leaves sixteen uncollected terms(1 + x)^4A few notes on how they are written:
duration. They cannot go flaky on a slow machine, and a regression fails the run
instead of hanging CI.
does not depend on the form the solver hands the roots back in. The 25×26 system from
the same report is a question of scale and is left open at
#608.
what the issue reported was the crash, and that is what is pinned.
I checked two neighbours that looked like they belonged here and do not, so they
are deliberately absent:
lim x→0+ (1/x + ln(x))still comes back unevaluated, not+oo. The twoterms diverge in opposite directions and deciding the sum needs the rates compared.
"arcsin(x)".Limit("x", "+oo")still comes back unevaluated. The relatedarcsin(x)/xat 0 does give 1, but that is not what was reported.Testing
UnitTests3669 passed / 0 failed. The branch ismasterplus one new test file, sothe numbers are master's own plus these eleven tests.
This is the fourth of four independent PRs — the others are #663, #664 and #665, and
this one touches no file any of them touch.
🤖 Generated with Claude Code