build: Fix name and install destination of llvm_macros.cmake - #2161
Open
lgritz wants to merge 1 commit into
Open
build: Fix name and install destination of llvm_macros.cmake#2161lgritz wants to merge 1 commit into
lgritz wants to merge 1 commit into
Conversation
Fixes 1771 Primarily, this was about llvm_macros.cmake installing in the same location where we put the exported cmake config files. But I also realized, maybe it's not good to have exported cmake files that aren't prefixed with "OSL_" like the others, so I renamed it, too. I will only have that in 1.16, so it will not break people in release branches. Signed-off-by: Larry Gritz <lg@larrygritz.com>
jfpanisset
approved these changes
Sep 7, 2026
jfpanisset
left a comment
jfpanisset
left a comment
Contributor
There was a problem hiding this comment.
Looks good, building and installing "everything" into /usr/local/ in the ci-vfxall images is a good way to catch projects which land files in unexpected places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1771
Primarily, this was about llvm_macros.cmake installing in the same location where we put the exported cmake config files.
But I also realized, maybe it's not good to have exported cmake files that aren't prefixed with "OSL_" like the others, so I renamed it, too. I will only have that in 1.16, so it will not break people in release branches.