fix: expose GST duty head on ledgers - #53
Open
benzene73 wants to merge 1 commit into
Open
Conversation
Member
|
I am going to achieve this repo my initial though of separate services, model per version made this library hard to maintain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GSTDUTYHEADasLedger.GSTDutyHeadGSTTaxTypeenum for CGST, SGST/UTGST, IGST, cess, and UT tax valuesGSTDUTYHEADIGSTledger fixtureWhy
Tally's documented ledger schema stores the specific GST tax head in
GSTDutyHead: https://help.tallysolutions.com/article/DeveloperReference/tdlreference/gst_schema.htm/The current model exposes
GSTTaxTypethrough theGSTTYPEXML element. Because v3 generates a TDL report from declared model fields, ordinary ledger reads currently omitGSTDUTYHEAD. In a live TallyPrime 7 read, the SDK response for an IGST ledger contained<TAXTYPE>GST</TAXTYPE>but no specific head; explicitly fetching$GSTDutyHeadreturnedIGST.This adds the documented field without changing or removing the existing
GSTTaxTypeproperty.Test