Skip to content

fix(release): pass bundle version to the Tauri compilation - #1535

Open
TimeToBuildBob wants to merge 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:fix/tauri-bundle-version-input
Open

TimeToBuildBob wants to merge 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:fix/tauri-bundle-version-input

Conversation

@TimeToBuildBob

Copy link
Copy Markdown
Contributor

Summary

  • Export the original getversion.sh output as compile-time AW_VERSION in the Tauri build job, before research-suffix filename normalization.
  • Preserve stable, prerelease and Research Edition identity for the embedded server without changing package versions or the existing major.minor server-pin check.
  • Add a regression that executes the actual workflow version step for all three tag forms; all three fail before this change and pass afterward. Add PyYAML to the existing check job and run the regression there.

Verification

  • test_tauri_bundle_version.py: 3 passed.
  • Owned Python Ruff check/format and git diff --check passed.

Delivery boundary

Related to #1533 (version complaint only; export is separate). Requires the companion aw-tauri change to consume AW_VERSION before server startup, then a bundle pin and published-artifact replay. This PR does not change the released v0.14.1 AppImage and must not close the issue.

Git-Session-Id: d494152b-cf95-4406-9a25-1b49eb4098ad
@greptile-apps

greptile-apps Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge within its stated workflow-only scope.

Summary

Exports the original bundle version as AW_VERSION before removing the Research Edition suffix from filenames.

  • Tauri release builds receive the original tag version in AW_VERSION.

TimeToBuildBob explicitly deferred the companion aw-tauri consumer change, bundle pin, and published-artifact replay. This PR does not update the released v0.14.1 AppImage or complete the related issue.

Reviews (1) · Last reviewed commit: "fix(release): pass bundle version to the..." · Reviewed by Greptile

@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

Greptile reports 5/5 with no requested changes, and the workflow regression check passed. Six platform builds are still running; no code change or rerun is needed now. Merge remains a maintainer action once CI completes. This workflow change alone does not resolve #1533; the companion consumer, bundle pin and published-artifact verification remain required.

@TimeToBuildBob

TimeToBuildBob commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 AI code review

The Tauri build job now exports the original getversion.sh output as AW_VERSION before removing the research suffix from filename versions. A new parametrized test executes that workflow step for stable, prerelease, and research tags and checks the exported values and build configuration. The research-edition check job installs PyYAML and runs the new test.

Safe to merge — no P0/P1 findings

Confidence 5/5

✅ No findings. The diff looks correct to me on this pass.

Files changed (2) — the diff as I read it
  • .github/workflows/release.yml — Exports AW_VERSION in the Tauri version step, adds pyyaml to check dependencies, and includes test_tauri_bundle_version.py in the release-version test command.
  • scripts/tests/test_tauri_bundle_version.py — Adds a parametrized workflow test using a stub getversion.sh to check AW_VERSION, normalized VERSION_WITH_V, step ordering, and build environment declarations.

Reviewed 57c99e4e37b2 · panel: codex:gpt-6.1-sol · subscription engine · 13s · about this reviewer

Maintainer commands

@TimeToBuildBob review (own line) — fresh review · @TimeToBuildBob fix — a worker acts on the findings. Once per comment; 👀 = received.

Outage coverage: 1-pass, not merge evidence. Subscription review supplied findings while full consensus capacity was unavailable. The consensus merge gate remains unsatisfied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant