Skip to content

fix(version): report the enclosing ActivityWatch bundle release - #293

Open
TimeToBuildBob wants to merge 2 commits into
ActivityWatch:masterfrom
TimeToBuildBob:fix/bundle-release-version
Open

TimeToBuildBob wants to merge 2 commits into
ActivityWatch:masterfrom
TimeToBuildBob:fix/bundle-release-version

Conversation

@TimeToBuildBob

Copy link
Copy Markdown
Contributor

Summary

  • Read Cargo-tracked compile-time AW_VERSION and apply the existing aw-server version override before GUI/mini/daemon dispatch.
  • Keep absent/empty development input on the server default; do not report the aw-tauri crate's 0.1.0 as the bundle version.
  • Add standalone rustc input regressions plus startup ordering coverage, run them in lint CI, and document the build contract.

Verification

  • Locked native cargo build with AW_VERSION=v0.14.2 passed (2 build jobs, private target directory).
  • Standalone regression: 2 tests passed, including five unset/empty/stable/prerelease/research compile inputs.
  • cargo fmt and hook-enabled commit checks passed.
  • Isolated native daemon and GUI-mode GET /api/0/info both returned v0.14.2. Ordinary visible footer verification is still being finalized; these API checks alone do not claim that surface passed.

Delivery boundary

Companion ActivityWatch/activitywatch#1535 exports the original bundle identity in release CI. Related to ActivityWatch/activitywatch#1533, version slice only. Requires both merges, a bundle pin and published-artifact replay; the export complaint remains separate. This does not repair the published v0.14.1 AppImage.

Git-Session-Id: d494152b-cf95-4406-9a25-1b49eb4098ad
@greptile-apps

greptile-apps Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge within its stated delivery boundary.

Summary

Reads compile-time AW_VERSION and applies the server override before choosing GUI, mini, or daemon mode.

  • The embedded server reports the enclosing ActivityWatch release.

Acknowledged boundary: TimeToBuildBob states that release exports belong to the companion change and require both merges, a bundle pin, and published-artifact replay. TimeToBuildBob also states that visible footer verification remains unfinished and that this does not repair the published v0.14.1 AppImage.

Review checks were source-only; tests were not run.

Reviews (1) · Last reviewed commit: "fix(version): report the enclosing Activ..." · Reviewed by Greptile

@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

Greptile reports 5/5 with no requested changes, and format, clippy and the macOS build have passed. The other four platform builds are still running; no fix or rerun is indicated. Leaving this for maintainer review once CI completes. The companion bundle input, bundle pin and published-artifact replay remain required, including the ordinary visible footer check.

@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click.

This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted.

@TimeToBuildBob

TimeToBuildBob commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 AI code review

Adds release_version::bundle_version() to read nonempty compile-time AW_VERSION and calls aw_server::version::set_version_override(version) at the start of run(). Adds standalone Python tests for compile-time inputs and startup ordering, runs them in lint CI, and documents the bundle version build contract.

Safe to merge — no P0/P1 findings

Confidence 5/5

✅ No findings. The diff looks correct to me on this pass.

Files changed (5) — the diff as I read it
  • .github/workflows/lint.yml — Adds a format-job step running python3 tests/test_release_version.py.
  • README.md — Documents compile-time AW_VERSION, server version reporting, development fallback, research suffixes, and the standalone regression command.
  • src-tauri/src/lib.rs — Declares release_version and applies its bundle version through set_version_override before logging initialization and mode dispatch.
  • src-tauri/src/release_version.rs — Adds bundle_version() returning compile-time AW_VERSION, filtering out empty strings.
  • tests/test_release_version.py — Adds tests for Windows module path generation, five compile-time version inputs, and source ordering before daemon and mini dispatch.
Previous review passes
commit score findings engine when
20c23e7995ae 4/5 1 subscription 2026-10-23 10:03 UTC

Reviewed b8ec3d30588e · panel: codex:gpt-6.1-sol · subscription engine · 20s · about this reviewer

Maintainer commands

@TimeToBuildBob review (own line) — fresh review · @TimeToBuildBob fix — a worker acts on the findings. Once per comment; 👀 = received.

Outage coverage: 1-pass, not merge evidence. Subscription review supplied findings while full consensus capacity was unavailable. The consensus merge gate remains unsatisfied.

Comment thread tests/test_release_version.py Outdated
Git-Session-Id: 1f655d59-3d9e-5488-913b-32b9f54faba3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant