fix: ignore invalid index cache

Author: yjw

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.1.18] - 2026-06-14
+
+### Fixed
+- Cache reads no longer create cache directories, avoiding permission-related failures when the cache path is not writable.
+- A-share index loading now ignores invalid cached/API shapes instead of passing non-list data to the renderer.
+
 ## [0.1.17] - 2026-06-14
 
 ### Fixed

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "young-stock-cli"
-version = "0.1.17"
+version = "0.1.18"
 description = "A-share (China stock market) after-hours CLI — no login, no scraping tricks, just data."
 readme = "README.md"
 requires-python = ">=3.9"

src/young_stock/__init__.py

@@ -1,3 +1,3 @@
 """young-stock-cli: A-share after-hours CLI."""
 
-__version__ = "0.1.17"
+__version__ = "0.1.18"

src/young_stock/_core.py

@@ -252,6 +252,10 @@ def _cache_key(symbol: str, date_str: str, source: str) -> str:
 
 
 def _cache_path(symbol: str, date_str: str, source: str) -> Path:
+    return CACHE_DIR / date_str / _cache_key(symbol, date_str, source)
+
+
+def _cache_write_path(symbol: str, date_str: str, source: str) -> Path:
     d = CACHE_DIR / date_str
     d.mkdir(parents=True, exist_ok=True)
     return d / _cache_key(symbol, date_str, source)
@@ -280,7 +284,7 @@ def cache_save(symbol: str, date_str: str, source: str, data: dict[str, Any]) ->
     payload = data.get("data") if isinstance(data, dict) else None
     if payload is not None and not payload:  # data: [] / data: {}
         return
-    p = _cache_path(symbol, date_str, source)
+    p = _cache_write_path(symbol, date_str, source)
     try:
         with open(p, "w", encoding="utf-8") as f:
             json.dump(data, f, ensure_ascii=False, default=str)
@@ -1603,13 +1607,17 @@ def normalize_stock_symbol(symbol: str) -> tuple[str, str]:
 def get_index(date_str: str) -> list[dict[str, Any]]:
     cached = cache_load("index_all", date_str, "eastmoney")
     if cached:
-        return cached.get("data", [])
+        cached_rows = cached.get("data")
+        if isinstance(cached_rows, list):
+            return cached_rows
+        diag("Ignored cached A-share index because data is not a list")
 
     url = INDEX_URL.format(secids=INDEX_SECIDS, fields=INDEX_FIELDS, ts=datetime.now().timestamp())
     data = fetch_json(url, {"Referer": "https://quote.eastmoney.com/"})
     if "_error" in data:
         diag(f"Eastmoney index: {data['_error']}")
-    result = data.get("data", {}).get("diff", []) if "_error" not in data else []
+    diff = data.get("data", {}).get("diff", []) if "_error" not in data else []
+    result = diff if isinstance(diff, list) else []
     # 东财失败时降级到新浪
     if not result:
         result = _fetch_a_indices_sina()

tests/test_core.py

@@ -37,6 +37,23 @@ def test_cache_key_deterministic():
     assert a == b
 
 
+def test_cache_load_missing_entry_does_not_create_directory(monkeypatch, tmp_path):
+    cache_dir = tmp_path / "cache"
+    monkeypatch.setattr(_core, "CACHE_DIR", cache_dir)
+
+    assert _core.cache_load("index_all", "20260612", "eastmoney") is None
+    assert not cache_dir.exists()
+
+
+def test_get_index_ignores_invalid_cached_shape(monkeypatch):
+    monkeypatch.setattr(_core, "cache_load", lambda *args, **kwargs: {"data": {"diff": "bad-shape"}})
+    monkeypatch.setattr(_core, "fetch_json", lambda *args, **kwargs: {"_error": "blocked"})
+    monkeypatch.setattr(_core, "_fetch_a_indices_sina", lambda: [])
+    monkeypatch.setattr(_core, "_fetch_a_indices_tencent", lambda: [])
+
+    assert _core.get_index("20260612") == []
+
+
 def test_hk_indices_use_full_hsi_quote_with_volume(monkeypatch):
     def fake_fetch_sina_batch(codes):
         assert "hkHSI" in codes

tests/test_packaging_docs.py

@@ -16,10 +16,10 @@ def test_package_version_is_next_patch_release():
     pyproject = (ROOT / "pyproject.toml").read_text(encoding="utf-8")
     init_py = (ROOT / "src" / "young_stock" / "__init__.py").read_text(encoding="utf-8")
 
-    assert 'version = "0.1.17"' in pyproject
+    assert 'version = "0.1.18"' in pyproject
     assert 'requires-python = ">=3.9"' in pyproject
     assert '"Programming Language :: Python :: 3.9"' in pyproject
-    assert '__version__ = "0.1.17"' in init_py
+    assert '__version__ = "0.1.18"' in init_py
 
 
 def test_ci_covers_python_39():