Repository navigation
fix: display Kimi K3.1 Pro model label - #7833
Conversation
|
Caution Review failedThe pull request is closed. No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Curated model entry sdks/python/agenta/sdk/agents/data/pi_models.curated.json, sdks/python/oss/tests/pytest/unit/agents/connections/test_model_catalog.py |
The curated data adds Kimi K3.1 Pro with its label, pricing, 1,048,576-token context window, and text, image, and video modalities. A Python test checks the published catalog entry. |
OpenRouter option labels web/packages/agenta-entities/tests/unit/prompt-model-groups.test.ts |
Frontend tests check the curated Kimi label and confirm that an uncatalogued OpenRouter model retains its prefixed value and uses its unprefixed ID as the option and selected label. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Merge Risk: 
Minimal · up to bc1b6
-
The catalog addition and label handling are ready to merge with no identified blocking risk.
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Website previewPreview URL: https://pr-7833-agenta-website-preview.mahmoud-637.workers.dev Built from |
Railway Preview Environment
Provisioning failed; no manual review time granted. Environment absence verified; retained storage requires separate provider accounting. Post |
2dd5943 to
bc1b60a
Compare
The playground could show a provider-style model string instead of the curated name
Kimi K3.1 Prowhen this OpenRouter model was selected.The SDK's published model catalog had no entry for
openrouter/moonshotai/kimi-k3.1-pro, so the playground label helpers had no curated label to resolve. This PR adds that entry and sets its label toKimi K3.1 Pro.Before: the catalog has no Kimi K3.1 Pro entry, and the UI uses fallback model-ID text.
After: the published catalog contains:
{ "id": "openrouter/moonshotai/kimi-k3.1-pro", "label": "Kimi K3.1 Pro" }The full OpenRouter ID remains the saved and runnable value. Only display metadata changes. The model facts come from OpenRouter's public model catalog. The generated Pi catalog is unchanged.
Tests
@agenta/entitiesbuild: 3 successful tasks.Kimi K3.1 Prothrough both playground label-helper paths in a focused cross-runtime smoke test, with the model value unchanged.pnpm lint-fixinweb, Ruff formatting and checks, andgit diff --checkpassed./mand/m/authrendered without browser exceptions at desktop and mobile sizes using local authentication stubs.The exact affected control was not reproduced in an authenticated playground browser session. Verification covers the real published SDK document and both traced UI label paths.
How to review
pi_models.curated.jsonfor the curated entry, source note, model facts, and display label.test_model_catalog.pyto see the entry read from the actual published capabilities document.prompt-model-groups.test.tsfor the picker and selected-label behavior, the unchanged runnable ID, and the unchanged fallback for uncatalogued models.