Skip to content

Fix wget host-folder resolution to prevent empty/zero-file website archives #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AhmadIbrahiim merged 3 commits into from
May 15, 2026
Merged

Fix wget host-folder resolution to prevent empty/zero-file website archives #93

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f68ac7
Initial plan
Copilot May 15, 2026
697bbf1
fix: robustly detect wget download folder before archiving
Copilot May 15, 2026
d61d292
chore: tighten wget resolving host regex
Copilot May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions wget/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,28 @@ const child = exec(`wget -mkEpnp --no-if-modified-since ${data.website}`);

// read stdout from the current child.
child.stderr.on("data",(response)=>{
const responseText = response.toString();

if(response.startsWith("Resolving "))
if(!website)
{
website= response.substring(response.indexOf('Resolve ')+11,response.indexOf(' ('))
const resolvingMatch = responseText.match(/Resolving\s+([^\s]+)\s+\(/);
if (resolvingMatch && resolvingMatch[1]) {
website = resolvingMatch[1];
}
}
io.emit(data.token,{progress:response})
io.emit(data.token,{progress:responseText})
})

child.stderr.on('close',(response)=>{
const websiteFolder = website || getWebsiteFolderName(data.website);

if (!websiteFolder) {
io.emit(data.token, { progress: "Unable to determine downloaded website folder." });
return;
}

io.emit(data.token,{progress:"Converting"})
archiver(website,io,data)
archiver(websiteFolder,io,data)
})

// Handle process termination and cleanup
Expand All @@ -53,4 +63,14 @@ function removePartiallyDownloadedFiles(website) {
}
});
}

function getWebsiteFolderName(websiteUrl) {
try {
const normalizedUrl = /^https?:\/\//i.test(websiteUrl) ? websiteUrl : `http://${websiteUrl}`;
const parsedUrl = new URL(normalizedUrl);
return parsedUrl.port ? `${parsedUrl.hostname}:${parsedUrl.port}` : parsedUrl.hostname;
} catch (error) {
return "";
}
}
}
Loading