Merge pull request #1 from AlexGavrilov939/refactoring

refactor: remove 'any' types and improve error handling

Author: AlexGavrilov939

backend/src/config/env.validation.ts

@@ -17,6 +17,7 @@ const envSchema = z.object({
       'Invalid private key format (must be 0x followed by 64 hex chars)',
     ),
   INK_SEPOLIA_RPC_URL: z.string().url('Invalid RPC URL'),
+  CHAIN_ID: z.coerce.number().default(763373),
 
   MINT_TOKEN_ADDRESS: z
     .string()
@@ -25,6 +26,12 @@ const envSchema = z.object({
   WEBHOOK_SECRET: z.string().min(32, 'Webhook secret must be at least 32 characters'),
 
   FRONTEND_URL: z.string().url().default('http://localhost:3000'),
+
+  SENTRY_DSN: z.string().url().optional(),
+  SENTRY_ENVIRONMENT: z.string().optional(),
+  SENTRY_RELEASE: z.string().optional(),
+  SENTRY_TRACES_SAMPLE_RATE: z.coerce.number().min(0).max(1).default(0.1),
+  SENTRY_PROFILES_SAMPLE_RATE: z.coerce.number().min(0).max(1).default(0.1),
 });
 
 export type EnvConfig = z.infer<typeof envSchema>;

backend/src/infra/database/connection.ts

@@ -1,17 +1,14 @@
 import * as dotenv from 'dotenv';
 import { drizzle } from 'drizzle-orm/postgres-js';
 import postgres from 'postgres';
+import { validateEnv } from '../../config/env.validation';
 import * as schema from './schema';
 
 dotenv.config();
 
-const connectionString = process.env.DATABASE_URL;
+const env = validateEnv();
 
-if (!connectionString) {
-  throw new Error('DATABASE_URL environment variable is not set');
-}
-
-export const client = postgres(connectionString, {
+export const client = postgres(env.DATABASE_URL, {
   max: 10,
   idle_timeout: 20,
   connect_timeout: 10000,

backend/src/infra/database/schema.ts

@@ -14,7 +14,7 @@ export const wallets = pgTable(
   {
     id: uuid('id').primaryKey().defaultRandom(),
     address: varchar('address', { length: 42 }).notNull().unique(),
-    email: varchar('email', { length: 255 }).notNull(),
+    email: varchar('email', { length: 255 }).notNull().unique(),
     createdAt: timestamp('created_at').defaultNow().notNull(),
     updatedAt: timestamp('updated_at').defaultNow().notNull(),
   },

backend/src/infra/monitoring/sentry.config.ts

@@ -1,32 +1,33 @@
 import * as Sentry from '@sentry/node';
 import { nodeProfilingIntegration } from '@sentry/profiling-node';
 import type { NestFastifyApplication } from '@nestjs/platform-fastify';
+import * as dotenv from 'dotenv';
+import { validateEnv } from '../../config/env.validation';
+
+dotenv.config();
 
 interface SentryConfig {
   dsn?: string;
   environment: string;
-  release?: string;
+  release: string;
   tracesSampleRate: number;
   profilesSampleRate: number;
   enabled: boolean;
 }
 
 function getSentryConfig(): SentryConfig {
-  const dsn = process.env.SENTRY_DSN;
-  const environment = process.env.SENTRY_ENVIRONMENT || process.env.NODE_ENV || 'development';
-  const release = process.env.SENTRY_RELEASE || `mint-flow-backend@${process.env.npm_package_version || '1.0.0'}`;
-
-  const tracesSampleRate = Number.parseFloat(process.env.SENTRY_TRACES_SAMPLE_RATE || '0.1');
-  const profilesSampleRate = Number.parseFloat(process.env.SENTRY_PROFILES_SAMPLE_RATE || '0.1');
+  const env = validateEnv();
 
-  const enabled = Boolean(dsn) && environment !== 'test';
+  const environment = env.SENTRY_ENVIRONMENT || env.NODE_ENV;
+  const release = env.SENTRY_RELEASE || `mint-flow-backend@1.0.0`;
+  const enabled = Boolean(env.SENTRY_DSN) && environment !== 'test';
 
   return {
-    dsn,
+    dsn: env.SENTRY_DSN,
     environment,
     release,
-    tracesSampleRate,
-    profilesSampleRate,
+    tracesSampleRate: env.SENTRY_TRACES_SAMPLE_RATE,
+    profilesSampleRate: env.SENTRY_PROFILES_SAMPLE_RATE,
     enabled,
   };
 }

backend/src/main.ts

@@ -2,23 +2,28 @@ import 'reflect-metadata';
 import { setupSwagger } from '@config/swagger.config';
 import fastifyCors from '@fastify/cors';
 import helmet from '@fastify/helmet';
+import { client } from '@infra/database/connection';
 import { initializeSentry } from '@infra/monitoring/sentry.config';
 import { ValidationPipe } from '@nestjs/common';
 import { NestFactory } from '@nestjs/core';
 import { FastifyAdapter, type NestFastifyApplication } from '@nestjs/platform-fastify';
 import { AppModule } from './app.module';
 
+let app: NestFastifyApplication;
+
 async function bootstrap() {
   initializeSentry();
 
-  const app = await NestFactory.create<NestFastifyApplication>(
+  app = await NestFactory.create<NestFastifyApplication>(
     AppModule,
     new FastifyAdapter({
       logger: true,
       trustProxy: true,
     }),
   );
 
+  app.enableShutdownHooks();
+
   // biome-ignore lint/suspicious/noExplicitAny: Fastify plugin type compatibility with NestJS adapter
   await app.register(helmet as any, {
     contentSecurityPolicy: {
@@ -62,8 +67,35 @@ async function bootstrap() {
   const port = Number(process.env.PORT) || 3001;
 
   await app.listen(port, '0.0.0.0');
+
+  console.log(`Application is running on port ${port}`);
 }
 
+async function gracefulShutdown(signal: string) {
+  console.log(`Received ${signal}, starting graceful shutdown...`);
+
+  try {
+    if (app) {
+      console.log('Closing application...');
+      await app.close();
+      console.log('Application closed successfully');
+    }
+
+    console.log('Closing database connection...');
+    await client.end();
+    console.log('Database connection closed');
+
+    console.log('Graceful shutdown completed');
+    process.exit(0);
+  } catch (error) {
+    console.error('Error during graceful shutdown:', error);
+    process.exit(1);
+  }
+}
+
+process.on('SIGTERM', () => gracefulShutdown('SIGTERM'));
+process.on('SIGINT', () => gracefulShutdown('SIGINT'));
+
 bootstrap().catch((error) => {
   console.error('Failed to start application:', error);
   process.exit(1);

backend/src/modules/minting/infrastructure/adapters/gelato-client.adapter.ts

@@ -27,7 +27,7 @@ export class GelatoClientAdapter implements IGelatoClientPort {
     const privateKey = this.configService.getOrThrow<string>('GELATO_SIGNER_PRIVATE_KEY');
     const rpcUrl = this.configService.getOrThrow<string>('INK_SEPOLIA_RPC_URL');
     this.tokenAddress = this.configService.getOrThrow<string>('MINT_TOKEN_ADDRESS');
-    this.chainId = 763373; // Ink Sepolia
+    this.chainId = this.configService.getOrThrow<number>('CHAIN_ID');
 
     this.relay = new GelatoRelay();
     this.provider = new ethers.JsonRpcProvider(rpcUrl);

backend/src/shared/filters/http-exception.filter.ts

@@ -1,12 +1,15 @@
 import type { ArgumentsHost, ExceptionFilter } from '@nestjs/common';
-import { Catch, HttpException, HttpStatus, Logger } from '@nestjs/common';
+import { Catch, HttpException, HttpStatus, Inject, Logger } from '@nestjs/common';
+import { ConfigService } from '@nestjs/config';
 import type { FastifyReply } from 'fastify';
 import { ZodError } from 'zod';
 
 @Catch()
 export class HttpExceptionFilter implements ExceptionFilter {
   private readonly logger = new Logger(HttpExceptionFilter.name);
 
+  constructor(@Inject(ConfigService) private readonly configService: ConfigService) {}
+
   catch(exception: unknown, host: ArgumentsHost): void {
     const ctx = host.switchToHttp();
     const reply = ctx.getResponse<FastifyReply>();
@@ -113,13 +116,15 @@ export class HttpExceptionFilter implements ExceptionFilter {
       };
     }
 
+    const nodeEnv = this.configService.get<string>('NODE_ENV', 'production');
+
     return {
       status: HttpStatus.INTERNAL_SERVER_ERROR,
       response: {
         error: {
           code: 'INTERNAL_ERROR',
           message:
-            process.env.NODE_ENV === 'development'
+            nodeEnv === 'development'
               ? exception instanceof Error
                 ? exception.message
                 : 'Unknown error'

frontend/app/error.tsx

@@ -0,0 +1,53 @@
+'use client';
+
+export default function Error({
+  error,
+  reset,
+}: {
+  error: Error & { digest?: string };
+  reset: () => void;
+}) {
+  return (
+    <div className="min-h-screen flex items-center justify-center bg-gray-50 dark:bg-gray-900 px-4">
+      <div className="max-w-md w-full bg-white dark:bg-gray-800 rounded-lg shadow-lg p-8 text-center">
+        <div className="mb-4">
+          <svg
+            className="mx-auto h-12 w-12 text-red-500"
+            fill="none"
+            viewBox="0 0 24 24"
+            stroke="currentColor"
+            aria-hidden="true"
+          >
+            <path
+              strokeLinecap="round"
+              strokeLinejoin="round"
+              strokeWidth={2}
+              d="M12 9v2m0 4h.01m-6.938 4h13.856c1.54 0 2.502-1.667 1.732-3L13.732 4c-.77-1.333-2.694-1.333-3.464 0L3.34 16c-.77 1.333.192 3 1.732 3z"
+            />
+          </svg>
+        </div>
+
+        <h2 className="text-2xl font-bold mb-4 text-gray-900 dark:text-white">
+          Something went wrong!
+        </h2>
+
+        <p className="text-gray-600 dark:text-gray-400 mb-6">
+          {error.message || 'An unexpected error occurred. Please try again.'}
+        </p>
+
+        {error.digest && (
+          <p className="text-xs text-gray-500 dark:text-gray-500 mb-6 font-mono">
+            Error ID: {error.digest}
+          </p>
+        )}
+
+        <button
+          onClick={reset}
+          className="w-full px-6 py-3 bg-blue-500 hover:bg-blue-600 text-white font-medium rounded-lg transition-colors duration-200 focus:outline-none focus:ring-2 focus:ring-blue-500 focus:ring-offset-2 dark:focus:ring-offset-gray-800"
+        >
+          Try again
+        </button>
+      </div>
+    </div>
+  );
+}

frontend/features/auth/components/WalletInfo.tsx

@@ -3,6 +3,7 @@
 import { useAuth } from '../hooks/useAuth';
 import { useState, useEffect } from 'react';
 import { ethers } from 'ethers';
+import type { AxiosError } from 'axios';
 
 const INK_SEPOLIA_RPC_URL = process.env.NEXT_PUBLIC_INK_SEPOLIA_RPC_URL || 'https://rpc-gel-sepolia.inkonchain.com';
 const EXPLORER_URL = process.env.NEXT_PUBLIC_EXPLORER_URL || 'https://explorer-sepolia.inkonchain.com';
@@ -148,7 +149,7 @@ export function WalletInfo() {
 
         {registrationError &&
          !isRegistered &&
-         (registrationError as any)?.response?.status !== 409 && (
+         (registrationError as AxiosError)?.response?.status !== 409 && (
           <div className="bg-red-50 dark:bg-red-900/20 border border-red-200 dark:border-red-800 rounded p-3">
             <p className="text-xs text-red-800 dark:text-red-200">
               Registration failed. Please try reconnecting.

frontend/features/auth/hooks/useAuth.ts

@@ -3,6 +3,7 @@
 import { useDynamicContext } from '@dynamic-labs/sdk-react-core';
 import { useMutation } from '@tanstack/react-query';
 import { useEffect, useState } from 'react';
+import type { AxiosError } from 'axios';
 import { apiClient } from '@/lib/api';
 import type { RegisterWalletRequest, RegisterWalletResponse } from '../types';
 
@@ -25,9 +26,10 @@ export function useAuth(): UseAuthReturn {
       try {
         const response = await apiClient.post<RegisterWalletResponse>('/wallets', data);
         return response.data;
-      } catch (error: any) {
+      } catch (error) {
+        const axiosError = error as AxiosError<{ error?: { code?: string } }>;
         // 409 Conflict means wallet already registered - treat as success
-        if (error?.response?.status === 409 || error?.response?.data?.error?.code === 'CONFLICT') {
+        if (axiosError?.response?.status === 409 || axiosError?.response?.data?.error?.code === 'CONFLICT') {
           return { success: true, alreadyRegistered: true };
         }
         throw error;
@@ -37,7 +39,7 @@ export function useAuth(): UseAuthReturn {
       console.log('✅ Wallet registered successfully:', data);
       setIsRegistered(true);
     },
-    onError: (error: any) => {
+    onError: (error) => {
       console.error('❌ Wallet registration failed:', error);
     },
   });
@@ -69,7 +71,7 @@ export function useAuth(): UseAuthReturn {
     };
 
     registerWallet();
-  }, [user, primaryWallet, isRegistered]);
+  }, [user, primaryWallet, isRegistered, registerWalletMutation]);
 
   const logout = async () => {
     setIsRegistered(false);