Skip to content

Fix test failures - #35

Merged
anna-grim merged 2 commits into
mainfrom
test-fixes
Jul 27, 2026
Merged

anna-grim merged 2 commits into
mainfrom
test-fixes

Conversation

@carshadi

Copy link
Copy Markdown
Member

Summary

Fix training test failures related to CPU AMP configuration and the refactored learning-rate scheduler.

Changes

  • Preserve explicitly configured training and validation AMP settings on CPU and configure GradScaler using the trainer’s actual device type. Note that both of these have been supported on CPU since PyTorch 2.3+
  • Update the stale scheduler test to reflect that the scheduler is local to Trainer.run().
  • Verify the scheduler horizon uses the total optimizer-step count and advances once per batch.

Testing

  • 66 passed
  • 1 subtest passed
  • 2 existing ome-zarr deprecation warnings remain.

carshadi added 2 commits July 24, 2026 11:04
- these have been supported on CPU since PyTorch 2.3
- Stale test assumed scheduler was a class attribute instead of local variable
@carshadi
carshadi requested a review from anna-grim July 24, 2026 11:14
@carshadi

Copy link
Copy Markdown
Member Author

The CI tests only fail because this library does not support Python 3.10. I will fix the actions in the next PR.

@anna-grim

Copy link
Copy Markdown
Collaborator

Looks good!

@anna-grim
anna-grim merged commit 522c7b2 into main Jul 27, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants