Commit efc931f
fix(errors): name which Tunarr auth problem it is, not just "check three things"
Closes the last verification gap from the hardening sweep. The real Tunarr here
has auth disabled, so the credential path could only be proven at the header
level. Verified it properly against a local stand-in server that actually
enforces basic auth and returns 401 — no change to the real Tunarr.
Result: correct credentials index normally; absent or wrong ones fail cleanly.
But both landed in the generic "check that tunarr_url is correct and Tunarr is
reachable (and that Tunarr basic auth, if you enabled it, is configured)" —
which asks the user to check three unrelated things when we already know
precisely which one is wrong.
_endpoint_status already tells us it's a 401/403, so:
- credentials set -> "Tunarr rejected the username and password (401)."
- no credentials set -> "This Tunarr requires a username and password (401),
and none are configured."
Two different problems with two different fixes; a user who set no credentials
does not need to be told to re-check the ones they don't have.
Verified against the enforcing stand-in (both messages fire correctly, correct
credentials still index) and re-checked against the real Tunarr for regressions:
still 4100 movies / 401 shows across 4 Plex sources.
348 tests pass.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent e969def commit efc931f
2 files changed
Lines changed: 52 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
185 | | - | |
| 185 | + | |
| 186 | + | |
186 | 187 | | |
187 | 188 | | |
188 | 189 | | |
189 | 190 | | |
190 | 191 | | |
191 | 192 | | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
192 | 206 | | |
193 | 207 | | |
194 | 208 | | |
| |||
0 commit comments