fix(es/22_Call): handle failed low-level getX calls - #946
Open
buyua9 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getX()calls before decoding return data.Response(false, data)and return an explicit fallback value on failure; decode only successful return data.Why
The Spanish tutorial's
callGetX()ignored thesuccessflag and unconditionally decodeddata. A failed low-level call can return an invalid or empty buffer, causing a generic decode revert instead of demonstrating an explicit failure path.Validation
git diff --checkand failure-branch assertions passed.npx solc@0.8.34 --base-path . --bin Languages/es/22_Metodo_llamar_es/Call.solpassed with the existing payable-fallback warning.codespellreported no findings.