Repository navigation
Extract catalog generated-surface ownership - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
Part of #2
Summary
scripts/catalog_surface.pyas the lower generated-surface ownership module for slugging, paper-note expectations, obsolete note detection, tracked-file discovery, manifest planning, output planning/comparison, and generated view freshness.scripts/generate_catalog.pyas the command adapter for writing generated files.scripts/validate_catalog.pyto usecatalog_surfacefor expected outputs and freshness checks instead of importing the generator command adapter.scripts/sql_corpus.pyhas no diff.Generated diff
make generate; the only generated repository-surface diff was the deterministicmanifest.jsonfile-list addition forscripts/catalog_surface.py.Validation
make generatepassed.PYTHONDONTWRITEBYTECODE=1 make checkpassed: catalog validation passed, generated check passed, SQL static check passed.PYTHONDONTWRITEBYTECODE=1 make sql-checkpassed: SQL static check passed;DATABASE_URLwas unset, so live PostgreSQL execution was skipped after static SQL checks.git diff --checkpassed.git diff --cached --checkpassed before commit.