Repository navigation
Conversation
Adds the checked-in data/seeds/false_cognates_seed.json dataset with 25 Spanish-English 4-Part Cards across HIGH_RISK and MILD_NUANCE severities, adds SeedDatabase.queryFalseCognates(), and verifies metadata and inflection expansion in PreprocessorTest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Feature request: Add the curated pedagogical seed dataset for Spanish–English false cognates (
false_cognates_seed.json) underdata/seeds/as specified indocs/DATA.mdanddocs/INGESTION.md.Solution
data/seeds/false_cognates_seed.jsonwith 25 handcrafted 4-Part Cards (lemma,apparent_english,actual_english,real_spanish_for_apparent,severity,disambiguation_tip,example_es,example_en) covering bothHIGH_RISKsemantic traps (éxito, carpeta, embarazada, soportar, realizar, actualmente, asistir, largo, librería, lectura, etc.) andMILD_NUANCEshifts (compromiso, educado, molestar, discutir, introducir).FalseCognatesExpanderto extract JSON string primitives viacontentOrNull.SeedDatabase.queryFalseCognates()and unit tests inPreprocessorTestvalidating 4-Part Card metadata and dictionary surface inflection expansion.