Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements the interactive reader engine in
//core/reader, providing sentence segmentation, automated interlinear glossing, token inspection, and the session state machine for both curated lessons and custom/imported texts.Components Implemented
//core/reader:ReaderModels.kt):ReaderMode:SENTENCE_FOCUSandPARAGRAPH.ReadingSource:Curated(lesson),CustomText(customText), andRawText(title, content).EnrichedSentence: tokens, interlinear glosses, translation scaffolding, and grammar callouts.TokenInspection: lemma, POS, English gloss, cognate rule notes, false cognate trap cards, clitic surgery deconstructions, and vault status.ReaderSessionState&SessionSummary.SentenceSegmenter.kt):¿,¡) and abbreviation boundary preservation (Dr.,Sr.,Dra., etc.).InterlinearAligner.kt):TokenInspector.kt):SessionSentenceBuilder.kt):ReaderSessionEngine.kt):SentenceSegmenterTest: Spanish sentence segmentation, inverted marks, and abbreviations.InterlinearAlignerTest: 1-to-1 literal gloss alignment, false cognate prioritization, clitic compounds.ReaderSessionEngineTest: Curated and custom text loading, navigation, toggles, token inspection, encounter logging, and vault actions.Verification
bazelisk run //:formatandbazelisk run //:format.checkpassed.bazelisk build --config=lint //...(Detekt) passed with 0 issues.bazelisk test //...passed all 25 tests across the workspace.