Skip to content

Commit b4791ec

Browse files
committed
ci: wire crypto satellite V8 (unit+integration) into the merged coverage gate
The crypto integration V8 was produced (test:integration:coverage → coverage/.v8/crypto-integration) but never uploaded, and neither the crypto unit nor integration V8 was downloaded into coverage/.v8/all in the coverage-report job. So crypto never reached the merged lcov and check-satellite-coverage.mjs failed it as a wiring error (no coverage data), which fails even in report-only. Add the missing crypto integration upload (test-integration job) and the crypto unit + integration downloads (coverage-report job), matching the ai/websockets wiring. Verified by simulating the root merge locally: crypto now yields src records in the merged lcov and clears its declared floors unit-only (lines 93.7% / functions 93.21% / branches 87.79% vs 80/80/75).
1 parent 573765e commit b4791ec

1 file changed

Lines changed: 24 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -747,6 +747,18 @@ jobs:
747747
path: coverage/.v8/ai-integration
748748
if-no-files-found: warn
749749

750+
# crypto integration V8 (written by test:integration:coverage to
751+
# coverage/.v8/crypto-integration in the "— crypto" step above). The
752+
# coverage-report job merges this with crypto's unit V8 so
753+
# check-satellite-coverage.mjs gates a real per-satellite MERGED number.
754+
- name: Upload raw satellite integration coverage (V8) — crypto
755+
if: always()
756+
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
757+
with:
758+
name: c8-raw-crypto-integration
759+
path: coverage/.v8/crypto-integration
760+
if-no-files-found: warn
761+
750762
test-e2e-demo:
751763
name: E2E (demo app)
752764
runs-on: ubuntu-latest
@@ -1162,6 +1174,12 @@ jobs:
11621174
name: c8-raw-ai-integration
11631175
path: coverage/.v8/all
11641176

1177+
- name: Download raw satellite integration coverage (V8) — crypto
1178+
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4
1179+
with:
1180+
name: c8-raw-crypto-integration
1181+
path: coverage/.v8/all
1182+
11651183
# websockets integration V8 is produced by the test-e2e-websockets job (a
11661184
# different job than test-integration above), now run under c8. This is why
11671185
# test-e2e-websockets is in this job's needs:.
@@ -1217,6 +1235,12 @@ jobs:
12171235
name: c8-raw-ai-unit
12181236
path: coverage/.v8/all
12191237

1238+
- name: Download raw satellite unit coverage (V8) — crypto
1239+
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4
1240+
with:
1241+
name: c8-raw-crypto-unit
1242+
path: coverage/.v8/all
1243+
12201244
- name: Aggregate coverage report (unit + integration, remapped to src)
12211245
run: npm run coverage:report
12221246

0 commit comments

Comments
 (0)