Skip to content

Commit 2ed04b9

Browse files
test(backend): update receipts and settlements test mocks and expectations
- Reorder constructor parameters in ReceiptsService tests to match implementation changes - Add groupId select to expense query expectation in receipts service test - Include findUnique mock for settlement in integration test setup
1 parent 8c86ebd commit 2ed04b9

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

apps/backend/src/receipts/receipts.service.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ describe('ReceiptsService', () => {
1717
const jobsQueue: any = {
1818
enqueueReceiptProcessing: jest.fn().mockResolvedValue(undefined),
1919
};
20-
const service = new ReceiptsService(prisma, s3, jobsQueue);
20+
const service = new ReceiptsService(prisma, jobsQueue, s3);
2121

2222
await service.createUploadUrl('expense-1', { extension: 'jpg' });
2323

@@ -42,11 +42,11 @@ describe('ReceiptsService', () => {
4242
const jobsQueue: any = {
4343
enqueueReceiptProcessing: jest.fn().mockResolvedValue(undefined),
4444
};
45-
const service = new ReceiptsService(prisma, s3, jobsQueue);
45+
const service = new ReceiptsService(prisma, jobsQueue, s3);
4646

4747
const result = await service.createUploadUrl('expense-1', { extension: 'png' });
4848

49-
expect(prisma.expense.findUnique).toHaveBeenCalledWith({ where: { id: 'expense-1' } });
49+
expect(prisma.expense.findUnique).toHaveBeenCalledWith({ where: { id: 'expense-1' }, select: { groupId: true } });
5050
expect(prisma.receipt.upsert).toHaveBeenCalledWith({
5151
where: { expenseId: 'expense-1' },
5252
update: {
@@ -83,7 +83,7 @@ describe('ReceiptsService', () => {
8383
const jobsQueue: any = {
8484
enqueueReceiptProcessing: jest.fn(),
8585
};
86-
const service = new ReceiptsService(prisma, s3, jobsQueue);
86+
const service = new ReceiptsService(prisma, jobsQueue, s3);
8787

8888
await expect(service.createUploadUrl('missing-expense', {})).rejects.toBeInstanceOf(NotFoundException);
8989
expect(s3.getPresignedUploadUrl).not.toHaveBeenCalled();

apps/backend/src/settlements/settlements.integration.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ describe('Settlement Flow (integration-ish)', () => {
2626
const prisma: any = {
2727
settlement: {
2828
findFirst: jest.fn().mockResolvedValue(null),
29+
findUnique: jest.fn().mockResolvedValue(null),
2930
},
3031
groupMember: {
3132
findMany: jest.fn().mockResolvedValue([{ userId: 'u1' }, { userId: 'u2' }]),

0 commit comments

Comments
 (0)