Dev (#24)

* feat(web): implement theming system with CSS variables

Replace hardcoded colors and styles in dashboard components and layout with CSS custom properties for dynamic theming support. Introduce ThemeToggle component for user-controlled theme switching.

* refactor(theme): standardize theming with CSS variables and update defaults

Replace remaining hardcoded color values in components and styles with CSS custom properties for full theming support. Switch default theme to dark mode, update light mode color palette for improved contrast and consistency, and refine theme resolution logic in ThemeProvider. This enhances maintainability and ensures uniform application of themes across layouts and UI elements.

* feat(ui): implement portal rendering for modals and enhance color theming

Add Portal component for improved modal rendering, refactor CreateExpenseModal and CreateGroupModal to use portals with updated z-indexes and backgrounds. Introduce cardSolid color variable for solid backgrounds in themes. Update dashboard to dynamically use group currency and label multi-group balances.

BREAKING CHANGE: Modal z-indexes adjusted for layering consistency.

* feat(groups): add soft delete functionality for groups

Introduce soft delete for groups in the database schema and backend service, allowing group owners to delete groups via a new API endpoint. Update frontend to include a delete group modal in group actions, with proper confirmation and action handling. Modify queries to exclude deleted groups from user summaries and dashboards.

BREAKING CHANGE: Group deletion now permanently removes group data from active views and balances.

* ci: add e2e tests to workflow

Add database services startup, migration, and Playwright installation to CI pipeline.
Configure Playwright for api and web test projects with web server setup.
Add invalidateUserDashboardCache method in RedisService.
Enhance getDashboard in GroupsService to fetch user groups.
Add dashboard.spec.ts e2e test file and test-results directory.

* build(ci): reorder workflow steps and update turbo dependencies

- Moved build step before lint and test in CI pipeline
- Changed Prisma migration to db push for faster database setup
- Added build dependency to lint task in turbo.json for proper execution order

* fix: PR review - restore theme switching, guard soft delete, fix modal animations, cleanup

- ThemeProvider: restore data-theme application to document elements
- layout.tsx: restore theme init script to prevent FOUC
- groups.service.ts: add existence and already-deleted checks in delete method
- CreateExpenseModal: restore AnimatePresence for exit animations
- ThemeToggle: remove unused imports and variables
- .gitignore: add test-results/ and remove committed artifact

Agent-Logs-Url: https://github.com/Arun-kushwaha007/FairShare/sessions/3067ae7f-0172-4370-8ac6-04de20b46b7c

Co-authored-by: Arun-kushwaha007 <121769639+Arun-kushwaha007@users.noreply.github.com>

* chore: remove accidentally committed build artifacts from packages/shared-types/src

Agent-Logs-Url: https://github.com/Arun-kushwaha007/FairShare/sessions/3067ae7f-0172-4370-8ac6-04de20b46b7c

Co-authored-by: Arun-kushwaha007 <121769639+Arun-kushwaha007@users.noreply.github.com>

* test(backend): update receipts and settlements test mocks and expectations

- Reorder constructor parameters in ReceiptsService tests to match implementation changes
- Add groupId select to expense query expectation in receipts service test
- Include findUnique mock for settlement in integration test setup

* refactor(theme): simplify theme provider and remove inline initialization script

- Remove theme initialization script from layout.tsx
- Refactor ThemeProvider to only resolve themes without applying DOM changes
- Hardcode dark background and text colors in globals.css
- Enhance ThemeToggle with framer-motion animations and resolved theme usage

* test(mobile): update login screen test to expect 'sign in' text and clean import

- Remove BOM from React import
- Change test assertion to check for 'Sign In' instead of 'Login'

* ci(config): add supabase database url and direct url environment variables

- Updated .env.example and added apps/backend/.env.example with new variables
- Modified CI workflow to include SUPABASE_DATABASE_URL and DIRECT_URL for database migration and testing jobs

* ci(e2e): expand environment variables for end-to-end testing

- Added JWT_REFRESH_SECRET, GOOGLE_CLIENT_ID, GOOGLE_CLIENT_SECRET, REDIS_URL, AWS_REGION, and S3_BUCKET
- Updated STRIPE_SECRET_KEY to use test key format for consistency in CI pipeline

* ci(e2e): include supabase environment variables in testing pipeline

- Added NEXT_PUBLIC_SUPABASE_URL, NEXT_PUBLIC_SUPABASE_ANON_KEY, and NEXT_PUBLIC_API_URL to CI e2e job
- Updated .env.example with NEXT_PUBLIC_SUPABASE_URL and NEXT_PUBLIC_SUPABASE_ANON_KEY placeholders for local development consistency

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Author: Arun-kushwaha007

.env.example

@@ -1,4 +1,5 @@
 SUPABASE_DATABASE_URL=
+DIRECT_URL=
 JWT_SECRET=
 JWT_REFRESH_SECRET=
 GOOGLE_CLIENT_ID=

.github/workflows/ci.yml

@@ -50,14 +50,49 @@ jobs:
       - name: Generate Prisma client
         run: pnpm --filter backend prisma:generate
 
+      - name: Build
+        run: pnpm build
+
       - name: Lint
         run: pnpm lint
 
       - name: Test
         run: pnpm test
 
-      - name: Build
-        run: pnpm build
+      - name: Start Database Services
+        run: docker compose up -d
+
+      - name: Migrate Database
+        env:
+          DATABASE_URL: postgresql://postgres:postgres@localhost:5432/fairshare?schema=public
+          SUPABASE_DATABASE_URL: postgresql://postgres:postgres@localhost:5432/fairshare?schema=public
+          DIRECT_URL: postgresql://postgres:postgres@localhost:5432/fairshare?schema=public
+          JWT_SECRET: supersecret
+          STRIPE_SECRET_KEY: test_key
+        run: pnpm --filter backend exec prisma db push
+
+      - name: Install Playwright Browsers
+        run: pnpm exec playwright install --with-deps
+
+      - name: Run E2E Tests
+        env:
+          CI: true
+          DATABASE_URL: postgresql://postgres:postgres@localhost:5432/fairshare?schema=public
+          SUPABASE_DATABASE_URL: postgresql://postgres:postgres@localhost:5432/fairshare?schema=public
+          DIRECT_URL: postgresql://postgres:postgres@localhost:5432/fairshare?schema=public
+          JWT_SECRET: supersecret
+          JWT_REFRESH_SECRET: refreshsecret
+          GOOGLE_CLIENT_ID: googleid
+          GOOGLE_CLIENT_SECRET: googlesecret
+          REDIS_URL: redis://localhost:6380
+          AWS_REGION: ap-south-1
+          S3_BUCKET: fairshare-test-bucket
+          STRIPE_SECRET_KEY: sk_test_key
+          NEXT_PUBLIC_APP_URL: http://localhost:3000
+          NEXT_PUBLIC_SUPABASE_URL: http://localhost:54321
+          NEXT_PUBLIC_SUPABASE_ANON_KEY: dummy-anon-key
+          NEXT_PUBLIC_API_URL: http://localhost:3001/api/v1
+        run: pnpm run e2e
 
       - name: Upload coverage
         if: always()

.gitignore

@@ -7,6 +7,7 @@ node_modules
 dist
 .next
 coverage
+test-results
 .agents
 .agent
 .turbo

apps/backend/.env.example

@@ -0,0 +1,15 @@
+SUPABASE_DATABASE_URL=postgresql://postgres:postgres@localhost:5432/fairshare
+DIRECT_URL=postgresql://postgres:postgres@localhost:5432/fairshare
+JWT_SECRET=fairshare_dev_jwt_secret_change_me
+JWT_REFRESH_SECRET=fairshare_dev_jwt_refresh_secret_change_me
+GOOGLE_CLIENT_ID=fairshare_dev_google_client_id
+GOOGLE_CLIENT_SECRET=fairshare_dev_google_client_secret
+REDIS_URL=redis://127.0.0.1:6380
+AWS_ACCESS_KEY_ID=fairshare_dev_aws_access_key
+AWS_SECRET_ACCESS_KEY=fairshare_dev_aws_secret
+AWS_REGION=ap-south-1
+S3_BUCKET=fairshare-dev-receipts
+STRIPE_SECRET_KEY=sk_test_fairshare_dummy_key
+STRIPE_WEBHOOK_SECRET=whsec_fairshare_dummy_webhook_secret
+CORS_ORIGINS=http://localhost:3000,http://localhost:8081,exp://*:*
+SENTRY_DSN=

apps/backend/prisma/schema.prisma

@@ -67,6 +67,7 @@ model Group {
   shareToken         String?           @unique
   shareEnabled       Boolean           @default(false)
   createdAt          DateTime          @default(now())
+  deletedAt          DateTime?
   creator            User              @relation("group_creator", fields: [createdBy], references: [id])
   members            GroupMember[]
   expenses           Expense[]

apps/backend/src/groups/groups.controller.ts

@@ -1,4 +1,4 @@
-import { Body, Controller, Get, Param, Patch, Post, UseGuards } from '@nestjs/common';
+import { Body, Controller, Delete, Get, Param, Patch, Post, UseGuards } from '@nestjs/common';
 import { Throttle } from '@nestjs/throttler';
 import { JwtAuthGuard } from '../auth/guards/jwt-auth.guard';
 import { CurrentUser } from '../common/decorators/current-user.decorator';
@@ -82,4 +82,9 @@ export class GroupsController {
   ) {
     return this.groupsService.toggleShare(id, user.sub, enabled);
   }
+
+  @Delete(':id')
+  remove(@Param('id') id: string, @CurrentUser() user: JwtPayload) {
+    return this.groupsService.delete(id, user.sub);
+  }
 }

apps/backend/src/groups/groups.service.ts

@@ -83,6 +83,7 @@ export class GroupsService {
             userId,
           },
         },
+        deletedAt: null,
       },
       orderBy: { createdAt: 'desc' },
     });
@@ -235,7 +236,10 @@ export class GroupsService {
 
   async getUserSummary(userId: string): Promise<{ totalBalanceCents: string }> {
     const balances = await this.prisma.balance.findMany({
-      where: { userId },
+      where: { 
+        userId,
+        group: { deletedAt: null }
+      },
       select: { amountCents: true },
     });
 
@@ -254,6 +258,7 @@ export class GroupsService {
             userId,
           },
         },
+        deletedAt: null,
       },
       include: {
         _count: {
@@ -670,6 +675,48 @@ export class GroupsService {
     };
   }
 
+  async delete(groupId: string, actorUserId: string): Promise<{ success: true }> {
+    const group = await this.prisma.group.findUnique({
+      where: { id: groupId },
+      select: { id: true, deletedAt: true },
+    });
+
+    if (!group) {
+      throw new NotFoundException('Group not found');
+    }
+
+    if (group.deletedAt) {
+      throw new NotFoundException('Group has already been deleted');
+    }
+
+    const membership = await this.prisma.groupMember.findUnique({
+      where: {
+        groupId_userId: {
+          groupId,
+          userId: actorUserId,
+        },
+      },
+    });
+
+    if (!membership || membership.role !== 'OWNER') {
+      throw new ForbiddenException('Only the group owner can delete the group');
+    }
+
+    await this.prisma.group.update({
+      where: { id: groupId },
+      data: { 
+        deletedAt: new Date(),
+        shareEnabled: false,
+        shareToken: null
+      },
+    });
+
+    await this.redis.invalidateGroupCache(groupId);
+    await this.redis.invalidateUserDashboardCache(actorUserId);
+
+    return { success: true };
+  }
+
   async resolvePendingInvites(userId: string, email: string): Promise<void> {
     const invites = await this.prisma.groupInvite.findMany({
       where: { email: email.toLowerCase() },

apps/backend/src/receipts/receipts.service.spec.ts

@@ -17,7 +17,7 @@ describe('ReceiptsService', () => {
     const jobsQueue: any = {
       enqueueReceiptProcessing: jest.fn().mockResolvedValue(undefined),
     };
-    const service = new ReceiptsService(prisma, s3, jobsQueue);
+    const service = new ReceiptsService(prisma, jobsQueue, s3);
 
     await service.createUploadUrl('expense-1', { extension: 'jpg' });
 
@@ -42,11 +42,11 @@ describe('ReceiptsService', () => {
     const jobsQueue: any = {
       enqueueReceiptProcessing: jest.fn().mockResolvedValue(undefined),
     };
-    const service = new ReceiptsService(prisma, s3, jobsQueue);
+    const service = new ReceiptsService(prisma, jobsQueue, s3);
 
     const result = await service.createUploadUrl('expense-1', { extension: 'png' });
 
-    expect(prisma.expense.findUnique).toHaveBeenCalledWith({ where: { id: 'expense-1' } });
+    expect(prisma.expense.findUnique).toHaveBeenCalledWith({ where: { id: 'expense-1' }, select: { groupId: true } });
     expect(prisma.receipt.upsert).toHaveBeenCalledWith({
       where: { expenseId: 'expense-1' },
       update: {
@@ -83,7 +83,7 @@ describe('ReceiptsService', () => {
     const jobsQueue: any = {
       enqueueReceiptProcessing: jest.fn(),
     };
-    const service = new ReceiptsService(prisma, s3, jobsQueue);
+    const service = new ReceiptsService(prisma, jobsQueue, s3);
 
     await expect(service.createUploadUrl('missing-expense', {})).rejects.toBeInstanceOf(NotFoundException);
     expect(s3.getPresignedUploadUrl).not.toHaveBeenCalled();

apps/backend/src/redis/redis.service.ts

@@ -61,6 +61,14 @@ export class RedisService {
     }
   }
 
+  async invalidateUserDashboardCache(userId: string): Promise<void> {
+    try {
+      await this.redis.del(`user:${userId}:dashboard`);
+    } catch (error) {
+      this.logger.warn(`Redis invalidate skipped: ${error instanceof Error ? error.message : 'unknown error'}`);
+    }
+  }
+
   private async safeGet(key: string): Promise<string | null> {
     try {
       return await this.redis.get(key);

apps/backend/src/settlements/settlements.integration.spec.ts

@@ -26,6 +26,7 @@ describe('Settlement Flow (integration-ish)', () => {
     const prisma: any = {
       settlement: {
         findFirst: jest.fn().mockResolvedValue(null),
+        findUnique: jest.fn().mockResolvedValue(null),
       },
       groupMember: {
         findMany: jest.fn().mockResolvedValue([{ userId: 'u1' }, { userId: 'u2' }]),