Repository navigation
Conversation
wcqqq1214
marked this pull request as ready for review
October 18, 2026 11:42
sourcery-ai
Bot
dismissed
their stale review
October 18, 2026 12:10
Sourcery withdrew this approval because the latest commits introduced blocking findings.
Contributor
Author
|
@sourcery-ai review |
Contributor
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. If the timestamp logic is wrong, persisted trace snapshots can retain incorrect ordering or timestamps after the code is reverted; those historical values are not automatically repaired. The impact is bounded to trace data and can be addressed by clearing or correcting affected records.
6 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the restart-test hang introduced after #10614 and the trace ordering and Windows test failures exposed afterward.
Modifications / 改动点
Mock and verify asynchronous trace cleanup in the restart test.
Keep snapshot timestamps increasing within each trace so older updates cannot overwrite completion when the clock repeats or moves backward. Span start/end times are unchanged.
Use short pytest parameter IDs to avoid Windows environment-variable length limits.
Move the dashboard test’s flush/cleanup off the event loop; allow a 30-second flush timeout with failure diagnostics.
This is NOT a breaking change. / 这不是一个破坏性变更。
Screenshots or Test Results / 运行截图或测试结果
ruff format .,ruff check ., andgit diff --checkpassed.02539ce38. Windows: 4622 passed, 62 skipped, no failures or errors. CI results.No WebUI or API schema changes; screenshots and documentation updates are not applicable.
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
📚 I checked the affected WebUI instructions and screenshots in
docs/zhanddocs/enagainst the changed navigation, page structure, and labels, and updated them in this PR (or explained why no documentation update is needed). For renamed, moved, or merged entry points, I included an old entry → new entry mapping in the docs and changelog./ 我已对照变化后的 WebUI 入口、页面结构和术语,核对并在本 PR 中更新
docs/zh和docs/en的相关操作说明与截图(或说明无需更新文档的原因)。入口改名、移动或合并时,已在文档和 changelog 中补充 旧入口 → 新入口 对照。🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Stabilize trace persistence ordering and cross-platform lifecycle tests.
Bug Fixes:
Tests: