Skip to content

fix: include scheduled tasks in backups - #10644

Merged
Soulter merged 1 commit into
AstrBotDevs:masterfrom
wcqqq1214:fix/backup-cron-jobs
Oct 21, 2026
Merged

Soulter merged 1 commit into
AstrBotDevs:masterfrom
wcqqq1214:fix/backup-cron-jobs

Conversation

@wcqqq1214

@wcqqq1214 wcqqq1214 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Built-in backups omit scheduled tasks because cron_jobs is missing from the shared model registry. Include it so tasks survive export and restore.

Modifications / 改动点

  • Register CronJob for backup export and import.

  • Add a real SQLite-to-ZIP-to-SQLite round-trip regression test.

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Legacy backups contain no tasks; restoring them in replace mode leaves the task table empty. Re-export from the original instance to retain tasks.

Screenshots or Test Results / 运行截图或测试结果

  • pytest tests/test_backup.py tests/unit/test_cron_manager.py -q: 125 passed (3 existing warnings).
  • ruff format ., ruff check ., and git diff --check: passed.

Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。

  • 📚 I checked the affected WebUI instructions and screenshots in docs/zh and docs/en against the changed navigation, page structure, and labels, and updated them in this PR (or explained why no documentation update is needed). For renamed, moved, or merged entry points, I included an old entry → new entry mapping in the documentation and changelog.
    / 我已对照变化后的 WebUI 入口、页面结构和术语,核对并在本 PR 中更新 docs/zh 和 docs/en 的相关操作说明与截图(或说明无需更新文档的原因)。入口改名、移动或合并时,已在文档和 changelog 中补充 旧入口 → 新入口 对照。

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txt 和 pyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Preserve scheduled tasks when exporting and restoring backups.

Bug Fixes:

  • Include scheduled tasks in built-in backup export and restore operations.

Tests:

  • Add an SQLite backup round-trip regression test to verify scheduled tasks are preserved.

@wcqqq1214
wcqqq1214 marked this pull request as ready for review October 20, 2026 05:31

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. Importing a backup will now restore scheduled jobs, which may run on the target and send messages or trigger other actions outside the team. Reverting stops future restores but cannot undo actions a restored job has already performed.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@Soulter
Soulter merged commit dfc434f into AstrBotDevs:master Oct 21, 2026
23 checks passed
@Soulter Soulter mentioned this pull request Oct 21, 2026
6 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants