Skip to content

feat(quarto): dynamically set codeRunner.default_method based on avai… - #1595

Closed
iamralch wants to merge 2 commits into
AstroNvim:mainfrom
iamralch:main
Closed

feat(quarto): dynamically set codeRunner.default_method based on avai…#1595
iamralch wants to merge 2 commits into
AstroNvim:mainfrom
iamralch:main

Conversation

@iamralch

Copy link
Copy Markdown
Contributor

Detects presence of "iron.core" and "molten.health" modules at runtime and sets codeRunner.default_method accordingly in the quarto-nvim plugin options.

…lable dependencies

Detects presence of "iron.core" and "molten.health" modules at runtime
and sets `codeRunner.default_method` accordingly in the quarto-nvim
plugin options.
@github-actions

Copy link
Copy Markdown

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@azdanov

azdanov commented Jul 30, 2025

Copy link
Copy Markdown
Member

Hey. What about slime? Although, I don't use this extension so no clue how it's supposed to work.

@iamralch

Copy link
Copy Markdown
Contributor Author

@azdanov slime is the default option. Do you want me to set it explicitly?

@azdanov

azdanov commented Jul 30, 2025

Copy link
Copy Markdown
Member

Nope, probably not needed if it's default. Just asking since I don't know anything about this plugin apart from reading docs.

Can there be a situation where a user has both iron and molten installed simultaneously?

@iamralch

iamralch commented Jul 30, 2025

Copy link
Copy Markdown
Contributor Author

I haven't used them in one configuration. I suspect that they are compatible. The difference is that molten is handling jupyter notebooks vs iron is a repl for python and other languages.

@azdanov

azdanov commented Jul 30, 2025

Copy link
Copy Markdown
Member

@Uzaaft Do you have any experience with these? I'm only certain of web dev stuff, this looks like data science.

Uzaaft
Uzaaft previously approved these changes Aug 2, 2025

@Uzaaft Uzaaft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I like how one plugin is prioritized over the other, but the community will provide feedback.

@Uzaaft
Uzaaft dismissed their stale review August 2, 2025 10:01

Actually I think this is the wrong way to go around it.

@Uzaaft

Uzaaft commented Aug 2, 2025

Copy link
Copy Markdown
Member

After a second lookover, I feel like this code smells too much.

@iamralch

iamralch commented Aug 4, 2025

Copy link
Copy Markdown
Contributor Author

@Uzaaft @azdanov thank you for the feedback. I am closing the PR.

@iamralch iamralch closed this Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants