Skip to content

feat(pack): add nushell language pack - #1601

Merged
azdanov merged 2 commits into
AstroNvim:mainfrom
cfbender:feat/nushell
Aug 5, 2025
Merged

feat(pack): add nushell language pack#1601
azdanov merged 2 commits into
AstroNvim:mainfrom
cfbender:feat/nushell

Conversation

@cfbender

@cfbender cfbender commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Closes #1594

📑 Description

Adds the nushell language pack

ℹ Additional Information

Wasn't 100% sure if conform installs it's own nufmt, but I was pretty sure it doesn't - so I put it in the readme as needing a local install.

@github-actions

github-actions Bot commented Aug 4, 2025

Copy link
Copy Markdown

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@azdanov

azdanov commented Aug 5, 2025

Copy link
Copy Markdown
Member

You're correct that it needs to be manually installed. Mason doesn't seem to have nufmt, and conform doesn't install dependencies, only sets up formatting capabilities.

@azdanov

azdanov commented Aug 5, 2025

Copy link
Copy Markdown
Member

Also, would be good to mention that nushell itself is a requirement, since lsp won't work without it.

Comment thread lua/astrocommunity/pack/nushell/init.lua Outdated

@azdanov azdanov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@azdanov
azdanov merged commit b22f8a5 into AstroNvim:main Aug 5, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add nushell pack

2 participants