Skip to content

fix(refactoring-nvim): fix dependencies and API usage for latest version - #1756

Merged
Uzaaft merged 1 commit into
AstroNvim:mainfrom
rami3l:fix/refactoring-nvim-update
Apr 23, 2026
Merged

fix(refactoring-nvim): fix dependencies and API usage for latest version#1756
Uzaaft merged 1 commit into
AstroNvim:mainfrom
rami3l:fix/refactoring-nvim-update

Conversation

@rami3l

@rami3l rami3l commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

📑 Description

The last update of this bundle is from more than 1 year ago, and both the dependencies and the APIs have changed quite a bit since then.

📖 Additional Information

See https://github.com/ThePrimeagen/refactoring.nvim#configuration for the example keymapping config.

Personally I would actually prefer having the users configure the keymap themselves for this plugin with rather rich functionalities... @Uzaaft what do you think?

@github-actions

github-actions Bot commented Apr 21, 2026

Copy link
Copy Markdown

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@rami3l
rami3l force-pushed the fix/refactoring-nvim-update branch from fa5d237 to e105aa4 Compare April 21, 2026 13:39
@Uzaaft

Uzaaft commented Apr 22, 2026

Copy link
Copy Markdown
Member

I just looked at the rewrite.
Holy fuck is that a sloppy rewrite.

I think we should keep the keymaps in here. astrocommunity is meant to cover both power users and people who just want a OOTB experience.

@rami3l

@rami3l

rami3l commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

I think we should keep the keymaps in here. astrocommunity is meant to cover both power users and people who just want a OOTB experience.

@Uzaaft Sure!

I just looked at the rewrite.

is that a sloppy rewrite.

You mean the recent rewrite of the refactoring plugin in question? Yup I was quite surprised when it requires expr = true among other stuff :|

@Uzaaft
Uzaaft merged commit 7c1a46d into AstroNvim:main Apr 23, 2026
32 checks passed
@rami3l
rami3l deleted the fix/refactoring-nvim-update branch April 23, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants