Skip to content

fix(dev-tools-nvim): capture new dependency on async - #1762

Closed
hakamadare wants to merge 2 commits into
AstroNvim:mainfrom
hakamadare:hakamadare/refactor-nvim-async
Closed

fix(dev-tools-nvim): capture new dependency on async#1762
hakamadare wants to merge 2 commits into
AstroNvim:mainfrom
hakamadare:hakamadare/refactor-nvim-async

Conversation

@hakamadare

Copy link
Copy Markdown
Contributor

📑 Description

Per ThePrimeagen/refactoring.nvim#519, which announces a major rewrite,
plenary.nvim is no longer a dependency (which is good because that
library is apparently no longer maintained?), but now there's a
dependency on lewis6991/async.nvim.

📖 Additional Information

The community recipe in editing-support has captured this update, but
since I had configured this recipe but not the editing-support recipe,
I got a storm of tracebacks complaining about a missing async()
method.

Per ThePrimeagen/refactoring.nvim#519, which announces a major rewrite,
`plenary.nvim` is no longer a dependency (which is good because that
library is apparently no longer maintained?), but now there's a
dependency on lewis6991/async.nvim.

The community recipe in `editing-support` has captured this update, but
since I had configured this recipe but not the `editing-support` recipe,
I got a storm of tracebacks complaining about a missing `async()`
method.
@github-actions

Copy link
Copy Markdown

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@hakamadare hakamadare changed the title fix(dev-tools.nvim): capture new dependency on async fix(dev-tools-nvim): capture new dependency on async Apr 28, 2026
@hakamadare
hakamadare marked this pull request as draft April 28, 2026 20:51
@hakamadare
hakamadare marked this pull request as ready for review April 28, 2026 20:51
@hakamadare hakamadare closed this May 1, 2026
@hakamadare

Copy link
Copy Markdown
Contributor Author

trying again with updated PR title, it's not clear to me how to make CI happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant