You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In a minimal lazy.nvim repro, the previous spec shape did not preserve fields such as opts, cmd, event, and dependencies on the main mcphub.nvim plugin spec. Running the mcphub healthcheck could then fail with:
attempt to concatenate local 'cmd' (a nil value)
After this change, the spec preserves those fields. lazy.nvim can use the existing opts = {} table for plugin setup, and mcphub.nvim reaches its normal dependency check. If mcp-hub is not installed, users get the expected missing dependency message instead of a nil cmd error.
Verification
Reproduced the pre-change healthcheck error:
attempt to concatenate local 'cmd' (a nil value)
Verified the parsed lazy spec after the change:
config nil
opts table
deps { "plenary.nvim" }
event "User AstroFile"
cmd "MCPHub"
Verified the post-change healthcheck path no longer raises the nil cmd error and instead reaches mcphub.nvim's expected missing dependency message when mcp-hub is not installed.
Ran Lua parse/dofile check: DOFILE_OK 1
Ran git diff --check
No PRs or branches were created by automation before this approved PR step.
Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:
Proper conventional commit scoping:
If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin
If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error
Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above
README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)
Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).
Proper usage of opts table rather than setting things up with the config function.
Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
specstable so lazy.nvim preserves the main mcphub.nvim spec fields.optstable, matching the existing AstroCommunity pattern and review checklist.mcp-hubbinary must be installed or configured separately.Why
Fixes #1767.
In a minimal lazy.nvim repro, the previous spec shape did not preserve fields such as
opts,cmd,event, anddependencieson the mainmcphub.nvimplugin spec. Running the mcphub healthcheck could then fail with:After this change, the spec preserves those fields. lazy.nvim can use the existing
opts = {}table for plugin setup, and mcphub.nvim reaches its normal dependency check. Ifmcp-hubis not installed, users get the expected missing dependency message instead of a nilcmderror.Verification
attempt to concatenate local 'cmd' (a nil value)config nilopts tabledeps { "plenary.nvim" }event "User AstroFile"cmd "MCPHub"cmderror and instead reaches mcphub.nvim's expected missing dependency message whenmcp-hubis not installed.DOFILE_OK 1git diff --checkNo PRs or branches were created by automation before this approved PR step.