Scope bad debt to collateral generations - #795
Open
KillariDev wants to merge 23 commits into
Open
Conversation
…-exploit-round-7 # Conflicts: # bots/liquidator/src/monitoring/pool-monitor.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exploit and impact
An underfunded liquidation could leave
25.225167308134521096 ETHof nominal bad debt after correct users redeemed the entire share claim supply and drained tracked collateral. The stale debt and residual nominal capacity survived into a fresh collateral cycle, allowing new collateral to enter an underbacked system.A second path existed through delayed truth-auction claims: debt finalized in the exhausted generation could be assigned to a vault after a later generation started. That understated current open interest and could make subsequent vault migration underflow and become unavailable.
Fix
badDebtGenerationand generation-tagged vault debt while preserving the original mapping value slot.auctionBadDebtGenerationat finalization and assign auction debt only when it still matches the pool generation.Regression coverage
Validation
bun run tsc3288 pass,16network-dependent pinned-Uniswap skips,0 fail,13317assertions across 331 filesbun run format:checkbun run checkbun run knipwith only 10 pre-existing configuration hintsbun run check:generated-clean24553 / 24576; SecurityPoolForker initcode49122 / 49152; forker runtime24014 / 24576origin/main; final diff checks clean