Sites: include a8c-owned sites for non-Automatticians - #113932
Merged
Conversation
Non-Automatticians have no is_a8c filter in the site list, but they can still be members of a8c-owned sites. Always request a8c-owned sites for them so those sites are not silently missing from the list. Claude-Session: https://claude.ai/code/session_01EE6fVjw6DZiarMheomhS1P
|
WordPress.com
Automattic for Agencies
|
p-jackson
marked this pull request as ready for review
August 31, 2026 04:45
matticbot
added
the
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Split the a8c filter reading into its own boolean so that include_a8c_owned and site_visibility no longer share a variable. Non-Automatticians keep site_visibility 'visible' by default; 'all' is opted into by search, account restore, or an Automattician wanting a8c-owned sites. Claude-Session: https://claude.ai/code/session_01EE6fVjw6DZiarMheomhS1P
arthur791004
approved these changes
Aug 31, 2026
github-actions
Bot
removed
the
[Status] Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of DOTMSD-1491
Proposed Changes
include_a8c_ownedsites for users who are not Automatticians. PreviouslyshouldIncludeA8COwnedrequiredisAutomattician, so a8c-owned sites were excluded for everyone else.is_a8cfilter is explicitly set tofalse.Why are these changes being made?
is_a8cfilter is only exposed to Automatticians, but a regular user can still be a member of an a8c-owned site. With the old logic those sites were silently missing from their site list, and there was no filter they could use to bring them back.Testing Instructions
Pre-merge Checklist
https://claude.ai/code/session_01EE6fVjw6DZiarMheomhS1P