Repository navigation
add DCB event scheduler - #441
Conversation
trimoq
left a comment
trimoq
left a comment
There was a problem hiding this comment.
just one small thing, other than that, it looks good
| public CompletableFuture<String> scheduleEvent(Instant scheduleTime, Event event) { | ||
| FutureStreamObserver<ScheduleToken>responseObserver = new FutureStreamObserver<>(new AxonServerException( | ||
| ErrorCategory.OTHER, | ||
| "An unknown error occurred while scheduling an Event. No response received from Server.", |
There was a problem hiding this comment.
If we receive no reponse from the server, would INSTRUCTION_ACK_ERROR be a sensible choice or is that intended for something else?
There was a problem hiding this comment.
Wouldn't some event scheduling error category make sense? OTHER seems awfully generic for something that can be pinpointed a bit better.
|
|
||
| /** | ||
| * Reschedules the scheduled event with the given {@code scheduleToken} and reschedule it | ||
| * to be published after given {@code triggerDuration}. If no event is provided, the original event will be |
There was a problem hiding this comment.
Nit: We can clarify the fact we are not requiring an Event by using @NonNull and @Nullable annotations on the parameters.
|
|
||
| eventScheduler.rescheduleEvent(RescheduleEventRequest.newBuilder() | ||
| .setToken(scheduleToken) | ||
| .setEvent(event) |
There was a problem hiding this comment.
I guess the RescheduleEventRequest is okay with null Event inputs?
smcvb
left a comment
smcvb
left a comment
There was a problem hiding this comment.
I trust in your judgment that this change is valid.
|
No description provided.