Travel builder - #1657
Merged
Merged
Conversation
- Replace shared findPath with A* (exit-on-pop) for optimal straight paths - Add on-road cost discount so paths actively seek roads - Add 50% off-road speed penalty for travel time - Make Segment.from/to optional to fix false errors from cell-0 sentinel - Split Set start/Set end from Add segment to fix double-click issue - Fix biome lint: optional chains, forEach returns, void returns
Drag, insert and remove path points on the map, constrained to terrain the transport can actually cross. Stretched edges refill with collinear points so paths stay editable. Add per-segment note, color and visibility. Pin error tips so hovering no longer wipes them instantly.
Travel Builder — Journeys, a multi-segment travel map calculator.
Adapted to the refactors that landed on travel-builder while the PR was
open (it branched at 1.139.9, 413 commits back):
- Layers registry replaced public/modules/ui/layers.js: journeys is now a
registered Layer carrying the stroke defaults main.js used to set on the
group, with a LAYER_TOGGLES button. It sits above fogging, where main.js
appended the group. Draws go through Layers.draw("journeys") and editors
open with Layers.show("journeys").
- Generation moved into GenerationPipeline: Journeys.sync() and
Journeys.generateDemo() are pipeline steps in their former positions;
sync() also runs on load with the other module syncs.
- Save format: upstream shipped slots 47-51 (labels, style, relief, layers,
graphOverride), so journeys and transportTypes take 52 and 53 instead of
colliding with released saves.
- Renamed/removed helpers: destroyDialogIfExists -> destroyDialog,
findCell -> Pack.findCell, Node.prototype.on -> addEventListener.
Typecheck, biome, vite build and all 479 unit tests pass.
Owner
Author
|
Hi @msuyar, I'm mostly done with editing, you can review it now. |
Contributor
|
Hi, thanks for getting back to me. At the moment I am out of town but
tomorrow I will be home hopefully. I will reviee it than if its possible.
Thanks for the work you are doing
Muhammed Said Uyar
…On Sat, Aug 29, 2026, 16:32 Azgaar ***@***.***> wrote:
*Azgaar* left a comment (Azgaar/Fantasy-Map-Generator#1657)
<#1657 (comment)>
Hi @msuyar <https://github.com/msuyar>, I'm mostly done with editing, you
can review it now.
—
Reply to this email directly, view it on GitHub
<#1657?email_source=notifications&email_token=A4I2GUYEWTNSTE4G3ORKMSL5MLLPXA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNBWGI3TAMBQGI32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5462700027>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4I2GU67WPEY2SNQAHYZRLT5MLLPXAVCNFSNUABEKJSXA33TNF2G64TZHM4DKMRUGEYTIOB3JFZXG5LFHM2TEOBWHAYDANRQGKQXMAQ>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/A4I2GUYHEPQSDRUTMFMFVNL5MLLPXA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNBWGI3TAMBQGI32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/A4I2GU2BMUTYCEM5U4MGOPT5MLLPXA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNBWGI3TAMBQGI32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Resolve the style-migration conflicts: the base rewrote every preset from the legacy selector-keyed format to the registry-keyed store, so the branch's "#journeys" preset block is re-expressed as a `journeys` layer. - styles-schema.ts: a journeys layer with no `stroke` - each segment carries its own colour from the journey data - default-styles.json + the 11 shipped presets: the journeys defaults, placed after `routes` where the legacy "#journeys" block sat - styles-legacy.ts: a "#journeys" route, so presets and maps saved by earlier travel-builder builds still upgrade - style-presets.js: took the base's version - collectStyleData is gone, presets now serialize the store directly Also repairs two imports the base branch left broken (a still-used savedMessage dropped from save.ts, a non-existent calculateVoronoi added to load.ts). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description