Skip to content

Commit 2241b9e

Browse files
Allow additional Application Insights tables in E2E tests (#646)
* test: allow additional Application Insights tables * test: validate result shape before table names
1 parent 5a8a712 commit 2241b9e

1 file changed

Lines changed: 10 additions & 14 deletions

File tree

azure-kusto-data/tests/test_e2e_data.py

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -301,15 +301,13 @@ def test_log_analytics_query(self):
301301
pytest.skip("No application insights connection string provided")
302302
with self.get_client(True) as client:
303303
result = client.execute_mgmt(self.ai_test_db, self.ai_test_table_cmd)
304-
counter = 0
305-
expected_table_name = iter(self.application_insights_tables())
304+
assert len(result.primary_results) == 1
306305

307-
for primary in result.primary_results:
308-
counter += 1
309-
for row in primary.rows:
310-
assert row["TableName"] == expected_table_name.__next__()
306+
actual_table_names = {row["TableName"] for primary in result.primary_results for row in primary.rows}
307+
expected_table_names = set(self.application_insights_tables())
308+
missing_table_names = expected_table_names - actual_table_names
311309

312-
assert counter == 1
310+
assert not missing_table_names, f"Missing expected Application Insights tables: {sorted(missing_table_names)}"
313311
assert result.errors_count == 0
314312
assert result.get_exceptions() == []
315313

@@ -319,15 +317,13 @@ async def test_log_analytics_query_async(self):
319317
pytest.skip("No application insights connection string provided")
320318
async with await self.get_async_client(True) as ai_client:
321319
result = await ai_client.execute_mgmt(self.ai_test_db, self.ai_test_table_cmd)
322-
counter = 0
323-
expected_table_name = iter(self.application_insights_tables())
320+
assert len(result.primary_results) == 1
324321

325-
for primary in result.primary_results:
326-
counter += 1
327-
for row in primary.rows:
328-
assert row["TableName"] == expected_table_name.__next__()
322+
actual_table_names = {row["TableName"] for primary in result.primary_results for row in primary.rows}
323+
expected_table_names = set(self.application_insights_tables())
324+
missing_table_names = expected_table_names - actual_table_names
329325

330-
assert counter == 1
326+
assert not missing_table_names, f"Missing expected Application Insights tables: {sorted(missing_table_names)}"
331327
assert result.errors_count == 0
332328
assert result.get_exceptions() == []
333329

0 commit comments

Comments
 (0)